Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): removes global leaks to userLogs and adds additional noti… #18452

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 4, 2021

…fications for user

Pull request checklist

Description of changes

  • adds better notification to user if migrated package doesn't have any stories within react-examples
  • fixes global user logs memory leak

Focus areas to test

(optional)

@size-auditor
Copy link

size-auditor bot commented Jun 4, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f856cb3f7fbc3edb3646204c0c7e435fc7678dd1 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Dialog mount 2043 1303 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 804 775 5000
BaseButton mount 879 913 5000
Breadcrumb mount 2556 2544 1000
ButtonNext mount 462 468 5000
Checkbox mount 1453 1512 5000
CheckboxBase mount 1247 1252 5000
ChoiceGroup mount 4578 4532 5000
ComboBox mount 937 955 1000
CommandBar mount 9942 9845 1000
ContextualMenu mount 5995 6027 1000
DefaultButton mount 1108 1084 5000
DetailsRow mount 3675 3683 5000
DetailsRowFast mount 3622 3571 5000
DetailsRowNoStyles mount 3447 3447 5000
Dialog mount 2043 1303 1000 Possible regression
DocumentCardTitle mount 137 152 1000
Dropdown mount 3148 3222 5000
FocusTrapZone mount 1728 1752 5000
FocusZone mount 1729 1791 5000
IconButton mount 1681 1711 5000
Label mount 333 342 5000
Layer mount 1740 1737 5000
Link mount 457 444 5000
MakeStyles mount 1792 1746 50000
MenuButton mount 1416 1412 5000
MessageBar mount 1983 1988 5000
Nav mount 3228 3135 1000
OverflowSet mount 1008 1027 5000
Panel mount 2026 2013 1000
Persona mount 789 784 1000
Pivot mount 1344 1361 1000
PrimaryButton mount 1208 1214 5000
Rating mount 7406 7436 5000
SearchBox mount 1335 1269 5000
Shimmer mount 2516 2428 5000
Slider mount 1892 1872 5000
SpinButton mount 4851 4786 5000
Spinner mount 423 432 5000
SplitButton mount 3051 3126 5000
Stack mount 490 485 5000
StackWithIntrinsicChildren mount 1501 1485 5000
StackWithTextChildren mount 4437 4429 5000
SwatchColorPicker mount 10063 9859 5000
Tabs mount 1373 1376 1000
TagPicker mount 2315 2343 5000
TeachingBubble mount 11393 11503 5000
Text mount 411 405 5000
TextField mount 1349 1326 5000
ThemeProvider mount 1174 1179 5000
ThemeProvider virtual-rerender 583 580 5000
ThemeProviderNext mount 6883 6904 5000
Toggle mount 769 789 5000
buttonNative mount 109 120 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 367 339 1.08:1
CardMinimalPerf.default 553 518 1.07:1
PortalMinimalPerf.default 180 168 1.07:1
SegmentMinimalPerf.default 345 322 1.07:1
AnimationMinimalPerf.default 405 383 1.06:1
AttachmentSlotsPerf.default 1151 1086 1.06:1
ButtonMinimalPerf.default 171 162 1.06:1
AvatarMinimalPerf.default 190 181 1.05:1
FlexMinimalPerf.default 292 278 1.05:1
RadioGroupMinimalPerf.default 458 436 1.05:1
SliderMinimalPerf.default 1606 1531 1.05:1
SplitButtonMinimalPerf.default 3757 3570 1.05:1
AttachmentMinimalPerf.default 156 150 1.04:1
CarouselMinimalPerf.default 452 435 1.04:1
ToolbarMinimalPerf.default 930 896 1.04:1
BoxMinimalPerf.default 359 350 1.03:1
EmbedMinimalPerf.default 4182 4077 1.03:1
GridMinimalPerf.default 329 320 1.03:1
ListMinimalPerf.default 507 491 1.03:1
IconMinimalPerf.default 592 573 1.03:1
ButtonOverridesMissPerf.default 1662 1636 1.02:1
ChatMinimalPerf.default 593 583 1.02:1
ChatWithPopoverPerf.default 360 353 1.02:1
DatepickerMinimalPerf.default 5389 5291 1.02:1
FormMinimalPerf.default 385 377 1.02:1
ItemLayoutMinimalPerf.default 1221 1202 1.02:1
MenuButtonMinimalPerf.default 1570 1536 1.02:1
ProviderMergeThemesPerf.default 1642 1614 1.02:1
StatusMinimalPerf.default 667 655 1.02:1
TooltipMinimalPerf.default 976 956 1.02:1
TreeWith60ListItems.default 167 164 1.02:1
AccordionMinimalPerf.default 151 150 1.01:1
ChatDuplicateMessagesPerf.default 282 279 1.01:1
DialogMinimalPerf.default 729 720 1.01:1
DividerMinimalPerf.default 357 352 1.01:1
DropdownManyItemsPerf.default 656 652 1.01:1
InputMinimalPerf.default 1244 1232 1.01:1
LabelMinimalPerf.default 372 369 1.01:1
LoaderMinimalPerf.default 665 657 1.01:1
MenuMinimalPerf.default 807 802 1.01:1
ProviderMinimalPerf.default 1006 992 1.01:1
TableMinimalPerf.default 402 398 1.01:1
TextMinimalPerf.default 339 335 1.01:1
TextAreaMinimalPerf.default 482 475 1.01:1
CustomToolbarPrototype.default 3798 3750 1.01:1
ButtonSlotsPerf.default 525 526 1:1
HeaderSlotsPerf.default 742 739 1:1
LayoutMinimalPerf.default 361 360 1:1
SkeletonMinimalPerf.default 352 353 1:1
TableManyItemsPerf.default 1829 1837 1:1
CheckboxMinimalPerf.default 2658 2673 0.99:1
DropdownMinimalPerf.default 3032 3078 0.99:1
PopupMinimalPerf.default 554 562 0.99:1
ListCommonPerf.default 597 609 0.98:1
ListNestedPerf.default 520 529 0.98:1
RosterPerf.default 1127 1155 0.98:1
ReactionMinimalPerf.default 369 376 0.98:1
ImageMinimalPerf.default 353 366 0.96:1
TreeMinimalPerf.default 774 804 0.96:1
RefMinimalPerf.default 214 225 0.95:1
VideoMinimalPerf.default 584 614 0.95:1
AlertMinimalPerf.default 249 266 0.94:1
ListWith60ListItems.default 589 625 0.94:1

@Hotell Hotell merged commit 7e44a88 into microsoft:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants