Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): add migration generator user input validations #18421

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 2, 2021

Pull request checklist

Description of changes

This is last phase for implementing migration generator with nx:

TASK:

  • migrate to typescript path aliases
  • migrate to use standard jest powered by TS path aliases
  • bootstrap new storybook config
  • collocate all package stories from react-examples
  • update npm scripts (setup docs task to run api-extractor for local changes verification)
  • add user input validation (THIS PR ✅)

Focus areas to test

(optional)

@Hotell Hotell changed the title Hotell/build system/nx migration generator for convergence 5 feat(tools): add migration generator user input validations Jun 2, 2021
@size-auditor
Copy link

size-auditor bot commented Jun 2, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3ae03cce030be209b4480332c2cb9551e140589f (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 782 791 5000
BaseButton mount 847 887 5000
Breadcrumb mount 2545 2537 1000
ButtonNext mount 473 473 5000
Checkbox mount 1462 1485 5000
CheckboxBase mount 1272 1252 5000
ChoiceGroup mount 4606 4548 5000
ComboBox mount 941 952 1000
CommandBar mount 9801 9944 1000
ContextualMenu mount 5919 5941 1000
DefaultButton mount 1104 1086 5000
DetailsRow mount 3600 3611 5000
DetailsRowFast mount 3513 3620 5000
DetailsRowNoStyles mount 3353 3302 5000
Dialog mount 2057 2058 1000
DocumentCardTitle mount 134 139 1000
Dropdown mount 3121 3110 5000
FocusTrapZone mount 1745 1724 5000
FocusZone mount 1744 1783 5000
IconButton mount 1708 1708 5000
Label mount 332 329 5000
Layer mount 1743 1787 5000
Link mount 448 457 5000
MakeStyles mount 1743 1744 50000
MenuButton mount 1446 1382 5000
MessageBar mount 1981 2005 5000
Nav mount 3156 3187 1000
OverflowSet mount 994 998 5000
Panel mount 2050 2018 1000
Persona mount 788 800 1000
Pivot mount 1346 1338 1000
PrimaryButton mount 1255 1237 5000
Rating mount 7433 7352 5000
SearchBox mount 1266 1231 5000
Shimmer mount 2484 2382 5000
Slider mount 1875 1872 5000
SpinButton mount 4826 4857 5000
Spinner mount 407 397 5000
SplitButton mount 3049 3029 5000
Stack mount 496 498 5000
StackWithIntrinsicChildren mount 1468 1468 5000
StackWithTextChildren mount 4365 4338 5000
SwatchColorPicker mount 9846 9823 5000
Tabs mount 1330 1363 1000
TagPicker mount 2357 2320 5000
TeachingBubble mount 11577 11476 5000
Text mount 401 413 5000
TextField mount 1335 1318 5000
ThemeProvider mount 1149 1147 5000
ThemeProvider virtual-rerender 572 584 5000
ThemeProviderNext mount 6745 6727 5000
Toggle mount 787 773 5000
buttonNative mount 111 111 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 154 144 1.07:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 367 343 1.07:1
PortalMinimalPerf.default 178 166 1.07:1
RefMinimalPerf.default 229 214 1.07:1
TreeWith60ListItems.default 171 160 1.07:1
LabelMinimalPerf.default 392 371 1.06:1
VideoMinimalPerf.default 626 593 1.06:1
ButtonMinimalPerf.default 164 156 1.05:1
FormMinimalPerf.default 391 371 1.05:1
ListWith60ListItems.default 625 598 1.05:1
StatusMinimalPerf.default 662 630 1.05:1
ButtonOverridesMissPerf.default 1668 1603 1.04:1
ButtonSlotsPerf.default 543 523 1.04:1
AvatarMinimalPerf.default 190 184 1.03:1
ListMinimalPerf.default 504 490 1.03:1
LoaderMinimalPerf.default 670 653 1.03:1
ReactionMinimalPerf.default 370 359 1.03:1
TextAreaMinimalPerf.default 491 477 1.03:1
AttachmentSlotsPerf.default 1103 1079 1.02:1
ChatMinimalPerf.default 593 579 1.02:1
DropdownManyItemsPerf.default 655 645 1.02:1
SkeletonMinimalPerf.default 343 337 1.02:1
SliderMinimalPerf.default 1516 1491 1.02:1
TextMinimalPerf.default 335 327 1.02:1
ToolbarMinimalPerf.default 915 899 1.02:1
AttachmentMinimalPerf.default 147 145 1.01:1
CardMinimalPerf.default 526 521 1.01:1
CarouselMinimalPerf.default 449 445 1.01:1
FlexMinimalPerf.default 281 279 1.01:1
GridMinimalPerf.default 339 334 1.01:1
HeaderSlotsPerf.default 746 738 1.01:1
LayoutMinimalPerf.default 348 343 1.01:1
ListCommonPerf.default 619 614 1.01:1
MenuButtonMinimalPerf.default 1527 1516 1.01:1
PopupMinimalPerf.default 549 545 1.01:1
RadioGroupMinimalPerf.default 424 418 1.01:1
CheckboxMinimalPerf.default 2670 2666 1:1
DatepickerMinimalPerf.default 5253 5231 1:1
DialogMinimalPerf.default 741 743 1:1
DividerMinimalPerf.default 353 353 1:1
InputMinimalPerf.default 1236 1235 1:1
ItemLayoutMinimalPerf.default 1229 1234 1:1
ListNestedPerf.default 541 542 1:1
ProviderMergeThemesPerf.default 1617 1609 1:1
TableManyItemsPerf.default 1831 1831 1:1
TooltipMinimalPerf.default 945 942 1:1
AnimationMinimalPerf.default 389 391 0.99:1
ChatWithPopoverPerf.default 347 351 0.99:1
DropdownMinimalPerf.default 2964 3003 0.99:1
EmbedMinimalPerf.default 3977 4008 0.99:1
RosterPerf.default 1126 1143 0.99:1
SegmentMinimalPerf.default 341 343 0.99:1
SplitButtonMinimalPerf.default 3620 3664 0.99:1
IconMinimalPerf.default 591 600 0.99:1
TableMinimalPerf.default 387 390 0.99:1
CustomToolbarPrototype.default 3630 3684 0.99:1
MenuMinimalPerf.default 803 821 0.98:1
TreeMinimalPerf.default 775 787 0.98:1
BoxMinimalPerf.default 331 341 0.97:1
ChatDuplicateMessagesPerf.default 275 284 0.97:1
AlertMinimalPerf.default 260 272 0.96:1
ImageMinimalPerf.default 347 363 0.96:1
ProviderMinimalPerf.default 910 944 0.96:1

@Hotell Hotell marked this pull request as ready for review June 2, 2021 12:56
@Hotell Hotell requested a review from a team as a code owner June 2, 2021 12:56
Copy link
Member

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants