Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): remove package dependency from react-examples #18402

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 1, 2021

Pull request checklist

Description of changes

Focus areas to test

(optional)

@Hotell Hotell marked this pull request as ready for review June 1, 2021 11:48
@Hotell Hotell requested a review from a team as a code owner June 1, 2021 11:48
@size-auditor
Copy link

size-auditor bot commented Jun 1, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 611c4220bf8df698e1ec774b17596d79b8de5c51 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 982 923 5000
BaseButton mount 1105 1084 5000
Breadcrumb mount 3120 3173 1000
ButtonNext mount 561 572 5000
Checkbox mount 1754 1755 5000
CheckboxBase mount 1499 1475 5000
ChoiceGroup mount 5297 5352 5000
ComboBox mount 1051 1090 1000
CommandBar mount 11274 11135 1000
ContextualMenu mount 7028 6995 1000
DefaultButton mount 1302 1282 5000
DetailsRow mount 4140 4153 5000
DetailsRowFast mount 4078 4175 5000
DetailsRowNoStyles mount 3895 3926 5000
Dialog mount 2302 2333 1000
DocumentCardTitle mount 163 168 1000
Dropdown mount 3643 3664 5000
FocusTrapZone mount 1831 1957 5000
FocusZone mount 1941 1980 5000
IconButton mount 2007 1963 5000
Label mount 372 363 5000
Layer mount 2033 1969 5000
Link mount 537 510 5000
MakeStyles mount 1936 1926 50000
MenuButton mount 1666 1645 5000
MessageBar mount 2244 2297 5000
Nav mount 3734 3692 1000
OverflowSet mount 1155 1120 5000
Panel mount 1543 2244 1000
Persona mount 942 923 1000
Pivot mount 1581 1612 1000
PrimaryButton mount 1455 1433 5000
Rating mount 8732 8855 5000
SearchBox mount 1507 1526 5000
Shimmer mount 2992 2907 5000
Slider mount 2142 2172 5000
SpinButton mount 5463 5537 5000
Spinner mount 473 455 5000
SplitButton mount 3680 3630 5000
Stack mount 595 546 5000
StackWithIntrinsicChildren mount 1809 1924 5000
StackWithTextChildren mount 5435 5522 5000
SwatchColorPicker mount 11528 11964 5000
Tabs mount 1561 1572 1000
TagPicker mount 2768 2756 5000
TeachingBubble mount 12646 12877 5000
Text mount 480 501 5000
TextField mount 1575 1570 5000
ThemeProvider mount 1334 1310 5000
ThemeProvider virtual-rerender 646 680 5000
ThemeProviderNext mount 7944 7550 5000
Toggle mount 916 888 5000
buttonNative mount 126 125 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 207 185 1.12:1
AttachmentMinimalPerf.default 181 168 1.08:1
ChatWithPopoverPerf.default 457 430 1.06:1
AlertMinimalPerf.default 328 312 1.05:1
ChatDuplicateMessagesPerf.default 366 349 1.05:1
DividerMinimalPerf.default 413 393 1.05:1
GridMinimalPerf.default 392 372 1.05:1
TableMinimalPerf.default 487 465 1.05:1
TextMinimalPerf.default 435 416 1.05:1
AnimationMinimalPerf.default 487 469 1.04:1
ButtonOverridesMissPerf.default 1880 1804 1.04:1
ListCommonPerf.default 745 718 1.04:1
SkeletonMinimalPerf.default 436 420 1.04:1
IconMinimalPerf.default 724 696 1.04:1
TreeWith60ListItems.default 206 198 1.04:1
CarouselMinimalPerf.default 539 525 1.03:1
ChatMinimalPerf.default 754 734 1.03:1
DialogMinimalPerf.default 852 828 1.03:1
FormMinimalPerf.default 483 467 1.03:1
HeaderMinimalPerf.default 430 416 1.03:1
InputMinimalPerf.default 1409 1368 1.03:1
ItemLayoutMinimalPerf.default 1449 1424 1.02:1
MenuMinimalPerf.default 974 951 1.02:1
RefMinimalPerf.default 251 246 1.02:1
StatusMinimalPerf.default 780 763 1.02:1
VideoMinimalPerf.default 799 780 1.02:1
BoxMinimalPerf.default 416 412 1.01:1
ButtonMinimalPerf.default 201 199 1.01:1
ButtonSlotsPerf.default 600 594 1.01:1
CheckboxMinimalPerf.default 2982 2946 1.01:1
EmbedMinimalPerf.default 4575 4538 1.01:1
FlexMinimalPerf.default 319 315 1.01:1
HeaderSlotsPerf.default 837 828 1.01:1
MenuButtonMinimalPerf.default 1809 1793 1.01:1
ProviderMergeThemesPerf.default 1822 1809 1.01:1
ReactionMinimalPerf.default 458 453 1.01:1
TooltipMinimalPerf.default 1221 1212 1.01:1
TreeMinimalPerf.default 942 937 1.01:1
CardMinimalPerf.default 639 639 1:1
DropdownMinimalPerf.default 3327 3334 1:1
ImageMinimalPerf.default 429 428 1:1
LabelMinimalPerf.default 448 448 1:1
ListMinimalPerf.default 576 574 1:1
ListNestedPerf.default 649 649 1:1
ListWith60ListItems.default 742 743 1:1
LoaderMinimalPerf.default 758 755 1:1
ProviderMinimalPerf.default 1172 1172 1:1
RadioGroupMinimalPerf.default 521 521 1:1
AttachmentSlotsPerf.default 1271 1279 0.99:1
AvatarMinimalPerf.default 225 228 0.99:1
SegmentMinimalPerf.default 390 393 0.99:1
SplitButtonMinimalPerf.default 4217 4251 0.99:1
TableManyItemsPerf.default 2227 2257 0.99:1
LayoutMinimalPerf.default 421 428 0.98:1
RosterPerf.default 1235 1264 0.98:1
SliderMinimalPerf.default 1718 1754 0.98:1
AccordionMinimalPerf.default 170 176 0.97:1
TextAreaMinimalPerf.default 637 655 0.97:1
ToolbarMinimalPerf.default 1064 1100 0.97:1
DropdownManyItemsPerf.default 756 787 0.96:1
CustomToolbarPrototype.default 4359 4530 0.96:1
PopupMinimalPerf.default 608 638 0.95:1
DatepickerMinimalPerf.default 5878 6254 0.94:1

@Hotell Hotell merged commit 11ca442 into microsoft:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants