-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "chore: enable Jest aliases for converged packages (#18337)" #18396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
approved these changes
May 31, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: fa961304d6ba90927e57abe23359e0cf9eaf66a9 (build) |
…hore/revert-18337
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 830 | 867 | 5000 | |
BaseButton | mount | 982 | 944 | 5000 | |
Breadcrumb | mount | 2653 | 2694 | 1000 | |
ButtonNext | mount | 522 | 527 | 5000 | |
Checkbox | mount | 1687 | 1656 | 5000 | |
CheckboxBase | mount | 1426 | 1364 | 5000 | |
ChoiceGroup | mount | 5045 | 5040 | 5000 | |
ComboBox | mount | 1046 | 1023 | 1000 | |
CommandBar | mount | 10238 | 10367 | 1000 | |
ContextualMenu | mount | 6462 | 6144 | 1000 | |
DefaultButton | mount | 1172 | 1228 | 5000 | |
DetailsRow | mount | 3891 | 3994 | 5000 | |
DetailsRowFast | mount | 3941 | 3873 | 5000 | |
DetailsRowNoStyles | mount | 3736 | 3757 | 5000 | |
Dialog | mount | 2212 | 2234 | 1000 | |
DocumentCardTitle | mount | 156 | 159 | 1000 | |
Dropdown | mount | 3355 | 3394 | 5000 | |
FocusTrapZone | mount | 1867 | 1864 | 5000 | |
FocusZone | mount | 1842 | 1833 | 5000 | |
IconButton | mount | 1869 | 1862 | 5000 | |
Label | mount | 354 | 373 | 5000 | |
Layer | mount | 1871 | 1897 | 5000 | |
Link | mount | 496 | 478 | 5000 | |
MakeStyles | mount | 1831 | 1820 | 50000 | |
MenuButton | mount | 1554 | 1595 | 5000 | |
MessageBar | mount | 2036 | 2018 | 5000 | |
Nav | mount | 3536 | 3463 | 1000 | |
OverflowSet | mount | 1115 | 1136 | 5000 | |
Panel | mount | 2138 | 2120 | 1000 | |
Persona | mount | 865 | 826 | 1000 | |
Pivot | mount | 1444 | 1451 | 1000 | |
PrimaryButton | mount | 1346 | 1376 | 5000 | |
Rating | mount | 8440 | 8360 | 5000 | |
SearchBox | mount | 1402 | 1418 | 5000 | |
Shimmer | mount | 2763 | 2774 | 5000 | |
Slider | mount | 2035 | 2028 | 5000 | |
SpinButton | mount | 5281 | 5363 | 5000 | |
Spinner | mount | 446 | 436 | 5000 | |
SplitButton | mount | 3321 | 3344 | 5000 | |
Stack | mount | 527 | 522 | 5000 | |
StackWithIntrinsicChildren | mount | 1634 | 1649 | 5000 | |
StackWithTextChildren | mount | 4961 | 4912 | 5000 | |
SwatchColorPicker | mount | 10835 | 10811 | 5000 | |
Tabs | mount | 1487 | 1471 | 1000 | |
TagPicker | mount | 2533 | 2621 | 5000 | |
TeachingBubble | mount | 12375 | 12466 | 5000 | |
Text | mount | 479 | 471 | 5000 | |
TextField | mount | 1582 | 1570 | 5000 | |
ThemeProvider | mount | 1262 | 1263 | 5000 | |
ThemeProvider | virtual-rerender | 634 | 626 | 5000 | |
ThemeProviderNext | mount | 6755 | 7096 | 5000 | |
Toggle | mount | 858 | 833 | 5000 | |
buttonNative | mount | 126 | 115 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 170 | 154 | 1.1:1 |
RefMinimalPerf.default | 254 | 231 | 1.1:1 |
VideoMinimalPerf.default | 731 | 666 | 1.1:1 |
FlexMinimalPerf.default | 322 | 302 | 1.07:1 |
CardMinimalPerf.default | 621 | 588 | 1.06:1 |
DialogMinimalPerf.default | 837 | 786 | 1.06:1 |
ImageMinimalPerf.default | 424 | 400 | 1.06:1 |
BoxMinimalPerf.default | 387 | 368 | 1.05:1 |
ButtonMinimalPerf.default | 183 | 175 | 1.05:1 |
FormMinimalPerf.default | 477 | 454 | 1.05:1 |
ListMinimalPerf.default | 548 | 520 | 1.05:1 |
TextMinimalPerf.default | 388 | 370 | 1.05:1 |
DatepickerMinimalPerf.default | 5777 | 5541 | 1.04:1 |
GridMinimalPerf.default | 375 | 360 | 1.04:1 |
ItemLayoutMinimalPerf.default | 1417 | 1365 | 1.04:1 |
LayoutMinimalPerf.default | 400 | 385 | 1.04:1 |
ListWith60ListItems.default | 704 | 678 | 1.04:1 |
PortalMinimalPerf.default | 177 | 171 | 1.04:1 |
AnimationMinimalPerf.default | 437 | 426 | 1.03:1 |
AttachmentSlotsPerf.default | 1209 | 1169 | 1.03:1 |
DropdownMinimalPerf.default | 3169 | 3087 | 1.03:1 |
ToolbarMinimalPerf.default | 1045 | 1011 | 1.03:1 |
ChatMinimalPerf.default | 659 | 645 | 1.02:1 |
DividerMinimalPerf.default | 389 | 382 | 1.02:1 |
ListNestedPerf.default | 617 | 607 | 1.02:1 |
ReactionMinimalPerf.default | 424 | 414 | 1.02:1 |
StatusMinimalPerf.default | 756 | 743 | 1.02:1 |
AlertMinimalPerf.default | 290 | 288 | 1.01:1 |
AvatarMinimalPerf.default | 208 | 205 | 1.01:1 |
ChatWithPopoverPerf.default | 389 | 386 | 1.01:1 |
LabelMinimalPerf.default | 419 | 415 | 1.01:1 |
MenuMinimalPerf.default | 895 | 888 | 1.01:1 |
SliderMinimalPerf.default | 1665 | 1643 | 1.01:1 |
TableManyItemsPerf.default | 2070 | 2041 | 1.01:1 |
ButtonOverridesMissPerf.default | 1746 | 1743 | 1:1 |
HeaderSlotsPerf.default | 840 | 837 | 1:1 |
LoaderMinimalPerf.default | 715 | 717 | 1:1 |
IconMinimalPerf.default | 660 | 660 | 1:1 |
TableMinimalPerf.default | 456 | 455 | 1:1 |
ButtonSlotsPerf.default | 577 | 585 | 0.99:1 |
CheckboxMinimalPerf.default | 2858 | 2888 | 0.99:1 |
InputMinimalPerf.default | 1305 | 1320 | 0.99:1 |
MenuButtonMinimalPerf.default | 1689 | 1714 | 0.99:1 |
PopupMinimalPerf.default | 578 | 584 | 0.99:1 |
SplitButtonMinimalPerf.default | 4026 | 4069 | 0.99:1 |
CustomToolbarPrototype.default | 3934 | 3989 | 0.99:1 |
TreeMinimalPerf.default | 859 | 867 | 0.99:1 |
ChatDuplicateMessagesPerf.default | 307 | 314 | 0.98:1 |
DropdownManyItemsPerf.default | 723 | 737 | 0.98:1 |
HeaderMinimalPerf.default | 402 | 412 | 0.98:1 |
SkeletonMinimalPerf.default | 376 | 385 | 0.98:1 |
TooltipMinimalPerf.default | 1077 | 1097 | 0.98:1 |
CarouselMinimalPerf.default | 486 | 500 | 0.97:1 |
EmbedMinimalPerf.default | 4268 | 4414 | 0.97:1 |
RosterPerf.default | 1244 | 1286 | 0.97:1 |
ProviderMinimalPerf.default | 1031 | 1065 | 0.97:1 |
TextAreaMinimalPerf.default | 539 | 554 | 0.97:1 |
TreeWith60ListItems.default | 187 | 192 | 0.97:1 |
ProviderMergeThemesPerf.default | 1663 | 1725 | 0.96:1 |
ListCommonPerf.default | 669 | 705 | 0.95:1 |
RadioGroupMinimalPerf.default | 481 | 504 | 0.95:1 |
SegmentMinimalPerf.default | 374 | 395 | 0.95:1 |
AccordionMinimalPerf.default | 157 | 168 | 0.93:1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR reverts #18337, it was designed as a temporary workaround for tests before #16889 will be completed, however it causes problem with Jest watch mode in some packages:
This happens because
@fluentui/scripts
are a part of Lerna project:fluentui/lerna.json
Line 2 in fa96130
But are configured in a different way and don't have
src/index
as an entrypoint. To implement it properly we will need to do something like:fluentui/scripts/webpack/getResolveAlias.js
Lines 22 to 28 in fa96130
That is definitely too much. Let's wait for #18337.