-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tools): implement jest updates for migration generator #18368
feat(tools): implement jest updates for migration generator #18368
Conversation
Co-authored-by: ling1726 <[email protected]> Co-authored-by: André <[email protected]>
@@ -72,6 +72,7 @@ | |||
"vrtest": "cd apps && cd vr-tests && yarn screener" | |||
}, | |||
"devDependencies": { | |||
"@angular-devkit/schematics": "12.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is nx bug as @nrlw/workspace
doesn't provide this package as it dependency although it's is using it internaly in few places. -> I'll report this to nrwl folks + send PR to fix it
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 203ccaf025da07d4064f8e4983298f0c1972c67d (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 826 | 856 | 5000 | |
BaseButton | mount | 891 | 886 | 5000 | |
Breadcrumb | mount | 2639 | 2632 | 1000 | |
ButtonNext | mount | 495 | 491 | 5000 | |
Checkbox | mount | 1495 | 1499 | 5000 | |
CheckboxBase | mount | 1253 | 1257 | 5000 | |
ChoiceGroup | mount | 4683 | 4667 | 5000 | |
ComboBox | mount | 956 | 976 | 1000 | |
CommandBar | mount | 9996 | 10169 | 1000 | |
ContextualMenu | mount | 6109 | 6076 | 1000 | |
DefaultButton | mount | 1100 | 1097 | 5000 | |
DetailsRow | mount | 3629 | 3674 | 5000 | |
DetailsRowFast | mount | 3668 | 3682 | 5000 | |
DetailsRowNoStyles | mount | 3460 | 3376 | 5000 | |
Dialog | mount | 2133 | 2132 | 1000 | |
DocumentCardTitle | mount | 120 | 136 | 1000 | |
Dropdown | mount | 3195 | 3181 | 5000 | |
FocusTrapZone | mount | 1751 | 1765 | 5000 | |
FocusZone | mount | 1792 | 1810 | 5000 | |
IconButton | mount | 1698 | 1673 | 5000 | |
Label | mount | 343 | 325 | 5000 | |
Layer | mount | 1755 | 1739 | 5000 | |
Link | mount | 472 | 467 | 5000 | |
MakeStyles | mount | 1779 | 1797 | 50000 | |
MenuButton | mount | 1444 | 1443 | 5000 | |
MessageBar | mount | 2012 | 1992 | 5000 | |
Nav | mount | 3260 | 3552 | 1000 | |
OverflowSet | mount | 1025 | 1024 | 5000 | |
Panel | mount | 2055 | 2025 | 1000 | |
Persona | mount | 829 | 816 | 1000 | |
Pivot | mount | 1380 | 1373 | 1000 | |
PrimaryButton | mount | 1268 | 1238 | 5000 | |
Rating | mount | 7466 | 7525 | 5000 | |
SearchBox | mount | 1263 | 1272 | 5000 | |
Shimmer | mount | 2537 | 2464 | 5000 | |
Slider | mount | 1924 | 1906 | 5000 | |
SpinButton | mount | 4900 | 4894 | 5000 | |
Spinner | mount | 416 | 403 | 5000 | |
SplitButton | mount | 3094 | 3111 | 5000 | |
Stack | mount | 499 | 503 | 5000 | |
StackWithIntrinsicChildren | mount | 1524 | 1547 | 5000 | |
StackWithTextChildren | mount | 4471 | 4462 | 5000 | |
SwatchColorPicker | mount | 10144 | 10076 | 5000 | |
Tabs | mount | 1385 | 1376 | 1000 | |
TagPicker | mount | 2373 | 2403 | 5000 | |
TeachingBubble | mount | 11713 | 11743 | 5000 | |
Text | mount | 413 | 426 | 5000 | |
TextField | mount | 1354 | 1362 | 5000 | |
ThemeProvider | mount | 1194 | 1174 | 5000 | |
ThemeProvider | virtual-rerender | 590 | 600 | 5000 | |
ThemeProviderNext | mount | 6845 | 6817 | 5000 | |
Toggle | mount | 814 | 791 | 5000 | |
buttonNative | mount | 107 | 122 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Potential regressions comparing to master
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
AlertMinimalPerf.default | 278 | 270 | 1.03:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ChatDuplicateMessagesPerf.default | 294 | 267 | 1.1:1 |
VideoMinimalPerf.default | 668 | 615 | 1.09:1 |
ButtonMinimalPerf.default | 174 | 162 | 1.07:1 |
PortalMinimalPerf.default | 182 | 170 | 1.07:1 |
AccordionMinimalPerf.default | 159 | 150 | 1.06:1 |
LayoutMinimalPerf.default | 372 | 352 | 1.06:1 |
PopupMinimalPerf.default | 589 | 557 | 1.06:1 |
CardMinimalPerf.default | 548 | 520 | 1.05:1 |
DatepickerMinimalPerf.default | 5542 | 5335 | 1.04:1 |
HeaderMinimalPerf.default | 361 | 347 | 1.04:1 |
TreeMinimalPerf.default | 800 | 770 | 1.04:1 |
AttachmentMinimalPerf.default | 158 | 153 | 1.03:1 |
ChatWithPopoverPerf.default | 364 | 353 | 1.03:1 |
FlexMinimalPerf.default | 287 | 278 | 1.03:1 |
FormMinimalPerf.default | 397 | 384 | 1.03:1 |
LoaderMinimalPerf.default | 696 | 673 | 1.03:1 |
RadioGroupMinimalPerf.default | 450 | 437 | 1.03:1 |
BoxMinimalPerf.default | 344 | 338 | 1.02:1 |
CarouselMinimalPerf.default | 458 | 449 | 1.02:1 |
ChatMinimalPerf.default | 617 | 602 | 1.02:1 |
EmbedMinimalPerf.default | 4142 | 4061 | 1.02:1 |
LabelMinimalPerf.default | 385 | 378 | 1.02:1 |
ListMinimalPerf.default | 504 | 496 | 1.02:1 |
StatusMinimalPerf.default | 666 | 655 | 1.02:1 |
IconMinimalPerf.default | 612 | 598 | 1.02:1 |
TextMinimalPerf.default | 345 | 339 | 1.02:1 |
ButtonSlotsPerf.default | 537 | 533 | 1.01:1 |
HeaderSlotsPerf.default | 742 | 737 | 1.01:1 |
ImageMinimalPerf.default | 367 | 362 | 1.01:1 |
ListNestedPerf.default | 536 | 530 | 1.01:1 |
SplitButtonMinimalPerf.default | 3733 | 3700 | 1.01:1 |
TableMinimalPerf.default | 404 | 400 | 1.01:1 |
CustomToolbarPrototype.default | 3851 | 3831 | 1.01:1 |
TreeWith60ListItems.default | 177 | 176 | 1.01:1 |
AttachmentSlotsPerf.default | 1118 | 1113 | 1:1 |
CheckboxMinimalPerf.default | 2715 | 2709 | 1:1 |
DividerMinimalPerf.default | 351 | 351 | 1:1 |
InputMinimalPerf.default | 1260 | 1255 | 1:1 |
ItemLayoutMinimalPerf.default | 1229 | 1229 | 1:1 |
ListCommonPerf.default | 614 | 617 | 1:1 |
MenuMinimalPerf.default | 829 | 827 | 1:1 |
ProviderMergeThemesPerf.default | 1655 | 1661 | 1:1 |
ProviderMinimalPerf.default | 996 | 999 | 1:1 |
RefMinimalPerf.default | 236 | 235 | 1:1 |
TableManyItemsPerf.default | 1865 | 1863 | 1:1 |
ToolbarMinimalPerf.default | 918 | 918 | 1:1 |
TooltipMinimalPerf.default | 976 | 975 | 1:1 |
AnimationMinimalPerf.default | 399 | 403 | 0.99:1 |
AvatarMinimalPerf.default | 191 | 193 | 0.99:1 |
DropdownMinimalPerf.default | 3042 | 3074 | 0.99:1 |
ReactionMinimalPerf.default | 366 | 370 | 0.99:1 |
SegmentMinimalPerf.default | 341 | 346 | 0.99:1 |
ButtonOverridesMissPerf.default | 1658 | 1686 | 0.98:1 |
DialogMinimalPerf.default | 733 | 747 | 0.98:1 |
DropdownManyItemsPerf.default | 661 | 673 | 0.98:1 |
MenuButtonMinimalPerf.default | 1517 | 1554 | 0.98:1 |
SliderMinimalPerf.default | 1562 | 1591 | 0.98:1 |
RosterPerf.default | 1128 | 1158 | 0.97:1 |
SkeletonMinimalPerf.default | 344 | 356 | 0.97:1 |
TextAreaMinimalPerf.default | 478 | 491 | 0.97:1 |
GridMinimalPerf.default | 320 | 333 | 0.96:1 |
ListWith60ListItems.default | 618 | 648 | 0.95:1 |
Co-authored-by: ling1726 [email protected]
Co-authored-by: André [email protected]
Pull request checklist
[ ] Include a change request file using$ yarn change
Description of changes
This is 2nd phase for implementing migration generator with nx:
TASK:
migrate to typescript path aliasesreact-examples
Focus areas to test
(optional)