Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): bootstrap migrate-converged-pkg generator phase 1 #18343

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 26, 2021

Co-authored-by: @andrefcdias, @ling1726

Pull request checklist

Description of changes

This is 1st phase for implementing migration generator with nx:

TASK:

  1. migrate to typescript path aliases - THIS PR ✅ (partially done)
  2. migrate to use standard jest powered by TS path aliases
  3. setup docs task to run api-extractor for local changes verification
  4. bootstrap new storybook config
  5. collocate all package stories from react-examples

Focus areas to test

(optional)

@Hotell Hotell marked this pull request as ready for review May 26, 2021 19:03
@Hotell Hotell requested a review from a team as a code owner May 26, 2021 19:03
@Hotell Hotell enabled auto-merge (squash) May 26, 2021 19:07
@size-auditor
Copy link

size-auditor bot commented May 26, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 004478f9f4363524f218ddf1f67da8c520488065 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9c0add8:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 26, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 807 861 5000
BaseButton mount 856 873 5000
Breadcrumb mount 2542 2554 1000
ButtonNext mount 482 475 5000
Checkbox mount 1428 1448 5000
CheckboxBase mount 1268 1235 5000
ChoiceGroup mount 4546 4557 5000
ComboBox mount 952 935 1000
CommandBar mount 9675 9710 1000
ContextualMenu mount 5934 5949 1000
DefaultButton mount 1114 1079 5000
DetailsRow mount 3552 3554 5000
DetailsRowFast mount 3583 3532 5000
DetailsRowNoStyles mount 3308 3347 5000
Dialog mount 2094 2062 1000
DocumentCardTitle mount 132 129 1000
Dropdown mount 3094 3066 5000
FocusTrapZone mount 1722 1743 5000
FocusZone mount 1785 1700 5000
IconButton mount 1716 1704 5000
Label mount 328 319 5000
Layer mount 1730 1671 5000
Link mount 455 450 5000
MakeStyles mount 1785 1708 50000
MenuButton mount 1425 1429 5000
MessageBar mount 1958 1980 5000
Nav mount 3088 3139 1000
OverflowSet mount 1016 986 5000
Panel mount 1981 1937 1000
Persona mount 773 786 1000
Pivot mount 1337 1343 1000
PrimaryButton mount 1244 1233 5000
Rating mount 7281 7277 5000
SearchBox mount 1246 1241 5000
Shimmer mount 2461 2453 5000
Slider mount 1844 1852 5000
SpinButton mount 4719 4720 5000
Spinner mount 425 411 5000
SplitButton mount 2976 3039 5000
Stack mount 473 469 5000
StackWithIntrinsicChildren mount 1462 1482 5000
StackWithTextChildren mount 4293 4301 5000
SwatchColorPicker mount 9952 10676 5000
Tabs mount 1331 1366 1000
TagPicker mount 2369 2255 5000
TeachingBubble mount 11417 11416 5000
Text mount 401 392 5000
TextField mount 1308 1317 5000
ThemeProvider mount 1141 1156 5000
ThemeProvider virtual-rerender 588 586 5000
ThemeProviderNext mount 6720 6785 5000
Toggle mount 765 777 5000
buttonNative mount 112 111 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 163 141 1.16:1
AttachmentMinimalPerf.default 158 139 1.14:1
ChatDuplicateMessagesPerf.default 291 255 1.14:1
TextAreaMinimalPerf.default 484 440 1.1:1
AnimationMinimalPerf.default 413 382 1.08:1
BoxMinimalPerf.default 343 322 1.07:1
ButtonSlotsPerf.default 535 503 1.06:1
ListWith60ListItems.default 630 592 1.06:1
TreeWith60ListItems.default 170 160 1.06:1
CardMinimalPerf.default 536 512 1.05:1
AttachmentSlotsPerf.default 1104 1060 1.04:1
HeaderSlotsPerf.default 734 707 1.04:1
ImageMinimalPerf.default 348 336 1.04:1
InputMinimalPerf.default 1266 1213 1.04:1
SkeletonMinimalPerf.default 341 327 1.04:1
VideoMinimalPerf.default 622 597 1.04:1
HeaderMinimalPerf.default 352 341 1.03:1
IconMinimalPerf.default 587 572 1.03:1
TextMinimalPerf.default 335 324 1.03:1
AvatarMinimalPerf.default 190 186 1.02:1
ChatMinimalPerf.default 592 581 1.02:1
CheckboxMinimalPerf.default 2635 2585 1.02:1
LayoutMinimalPerf.default 349 343 1.02:1
ListMinimalPerf.default 489 479 1.02:1
LoaderMinimalPerf.default 675 663 1.02:1
PortalMinimalPerf.default 170 166 1.02:1
RefMinimalPerf.default 227 223 1.02:1
TableMinimalPerf.default 390 381 1.02:1
ButtonOverridesMissPerf.default 1630 1613 1.01:1
DatepickerMinimalPerf.default 5165 5102 1.01:1
DividerMinimalPerf.default 347 343 1.01:1
FlexMinimalPerf.default 275 271 1.01:1
ItemLayoutMinimalPerf.default 1203 1189 1.01:1
ListNestedPerf.default 550 547 1.01:1
MenuButtonMinimalPerf.default 1509 1490 1.01:1
ProviderMinimalPerf.default 977 966 1.01:1
SegmentMinimalPerf.default 330 327 1.01:1
StatusMinimalPerf.default 641 635 1.01:1
CarouselMinimalPerf.default 434 435 1:1
EmbedMinimalPerf.default 3996 3991 1:1
FormMinimalPerf.default 389 389 1:1
MenuMinimalPerf.default 812 809 1:1
RadioGroupMinimalPerf.default 421 420 1:1
ReactionMinimalPerf.default 352 351 1:1
SplitButtonMinimalPerf.default 3580 3584 1:1
TableManyItemsPerf.default 1786 1780 1:1
CustomToolbarPrototype.default 3714 3696 1:1
TooltipMinimalPerf.default 940 941 1:1
TreeMinimalPerf.default 760 759 1:1
DialogMinimalPerf.default 719 728 0.99:1
DropdownManyItemsPerf.default 651 659 0.99:1
DropdownMinimalPerf.default 2972 3015 0.99:1
ListCommonPerf.default 585 593 0.99:1
PopupMinimalPerf.default 548 553 0.99:1
ToolbarMinimalPerf.default 906 914 0.99:1
AlertMinimalPerf.default 259 263 0.98:1
ChatWithPopoverPerf.default 348 354 0.98:1
SliderMinimalPerf.default 1513 1542 0.98:1
LabelMinimalPerf.default 348 360 0.97:1
ProviderMergeThemesPerf.default 1604 1655 0.97:1
ButtonMinimalPerf.default 153 159 0.96:1
RosterPerf.default 1059 1136 0.93:1
GridMinimalPerf.default 305 332 0.92:1

@Hotell Hotell merged commit 255924c into microsoft:master May 26, 2021
@Hotell Hotell added this to the May Project Cycle Q2 2021 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants