Move descendants to react-utilities #17528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the descendants utility from `react-accordion` to `react-utilities` and adds inline polyfills because of type leakage in component packages from `react-conformance` (see microsoft#17101)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 51a4c78:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 79a96df440ae8f477c049b6cb9c6d707e2a60ace (build) |
bsunderhus
approved these changes
Mar 24, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
* Move descendants to react-utilities This PR moves the descendants utility from `react-accordion` to `react-utilities` and adds inline polyfills because of type leakage in component packages from `react-conformance` (see microsoft#17101) * Change files * undo tsconfig change
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
* Move descendants to react-utilities This PR moves the descendants utility from `react-accordion` to `react-utilities` and adds inline polyfills because of type leakage in component packages from `react-conformance` (see microsoft#17101) * Change files * undo tsconfig change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the descendants utility from
react-accordiontoreact-utilitiesand adds inline polyfills because of type leakage incomponent packages from
react-conformance(see #17101)Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)