Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release CI test #17397

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix release CI test #17397

merged 1 commit into from
Mar 12, 2021

Conversation

ling1726
Copy link
Member

Recently #17161 changed react-menu to use native jest command for
testing which does not support the --production flag

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@ling1726
Fix release CI test
73a5089 
Recently microsoft#17161 changed `react-menu` to use native `jest` command for
testing which does not support the `--production` flag
@ling1726 ling1726 requested a review from ecraig12345 as a code owner March 12, 2021 19:25
@ecraig12345 ecraig12345 merged commit 3edcb92 into microsoft:master Mar 12, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 73a5089:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1119 1149 5000
BaseButton mount 882 898 5000
Breadcrumb mount 42236 42162 5000
ButtonNext mount 1196 1228 5000
Checkbox mount 1439 1429 5000
CheckboxBase mount 1252 1194 5000
ChoiceGroup mount 4568 4634 5000
ComboBox mount 939 922 1000
CommandBar mount 9830 9731 1000
ContextualMenu mount 5929 5994 1000
DefaultButton mount 1079 1067 5000
DetailsRow mount 3475 3487 5000
DetailsRowFast mount 3558 3486 5000
DetailsRowNoStyles mount 3264 3287 5000
Dialog mount 1443 1405 1000
DocumentCardTitle mount 1814 1790 1000
Dropdown mount 3220 3269 5000
FocusTrapZone mount 1749 1719 5000
FocusZone mount 1762 1796 5000
IconButton mount 1715 1680 5000
Label mount 330 327 5000
Layer mount 1737 1718 5000
Link mount 442 451 5000
MakeStyles mount 1923 1923 50000
MenuButton mount 1375 1371 5000
MessageBar mount 1945 1938 5000
Nav mount 3166 3170 1000
OverflowSet mount 995 1008 5000
Panel mount 1329 1397 1000
Persona mount 780 789 1000
Pivot mount 1404 1368 1000
PrimaryButton mount 1225 1252 5000
Rating mount 7202 7179 5000
SearchBox mount 1292 1280 5000
Shimmer mount 2447 2437 5000
Slider mount 1877 1909 5000
SpinButton mount 4716 4753 5000
Spinner mount 399 412 5000
SplitButton mount 3029 3107 5000
Stack mount 484 476 5000
StackWithIntrinsicChildren mount 1458 1495 5000
StackWithTextChildren mount 4408 4359 5000
SwatchColorPicker mount 9962 9842 5000
Tabs mount 1367 1356 1000
TagPicker mount 2717 2707 5000
TeachingBubble mount 11253 11320 5000
Text mount 407 403 5000
TextField mount 1388 1319 5000
ThemeProvider mount 1148 1153 5000
ThemeProvider virtual-rerender 604 599 5000
ThemeProviderNext mount 15577 15486 5000
Toggle mount 775 778 5000
buttonNative mount 110 107 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.17 0.47 0.36:1 2000 336
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 564
🔧 Checkbox.Fluent 0.64 0.35 1.83:1 1000 640
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 782
🔧 Dropdown.Fluent 3.08 0.42 7.33:1 1000 3081
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 672
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 393
🔧 Slider.Fluent 1.54 0.44 3.5:1 1000 1537
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 387
🦄 Tooltip.Fluent 0.14 0.87 0.16:1 5000 689

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 411 365 1.13:1
RefMinimalPerf.default 254 234 1.09:1
FormMinimalPerf.default 443 409 1.08:1
AnimationMinimalPerf.default 427 400 1.07:1
AttachmentMinimalPerf.default 166 157 1.06:1
PortalMinimalPerf.default 178 168 1.06:1
TableMinimalPerf.default 433 410 1.06:1
VideoMinimalPerf.default 648 613 1.06:1
ButtonMinimalPerf.default 184 176 1.05:1
IconMinimalPerf.default 693 662 1.05:1
ChatMinimalPerf.default 644 622 1.04:1
HeaderSlotsPerf.default 814 782 1.04:1
LabelMinimalPerf.default 442 426 1.04:1
ListMinimalPerf.default 528 509 1.04:1
TreeWith60ListItems.default 188 180 1.04:1
Text.Fluent 387 373 1.04:1
AlertMinimalPerf.default 309 300 1.03:1
AttachmentSlotsPerf.default 1218 1184 1.03:1
DialogMinimalPerf.default 790 770 1.03:1
DropdownManyItemsPerf.default 726 708 1.03:1
SegmentMinimalPerf.default 364 354 1.03:1
CustomToolbarPrototype.default 3714 3599 1.03:1
ToolbarMinimalPerf.default 954 926 1.03:1
DropdownMinimalPerf.default 3097 3044 1.02:1
InputMinimalPerf.default 1313 1292 1.02:1
LayoutMinimalPerf.default 421 411 1.02:1
ListCommonPerf.default 651 640 1.02:1
ListWith60ListItems.default 647 632 1.02:1
PopupMinimalPerf.default 691 677 1.02:1
ReactionMinimalPerf.default 425 418 1.02:1
SkeletonMinimalPerf.default 383 376 1.02:1
SliderMinimalPerf.default 1584 1556 1.02:1
TableManyItemsPerf.default 2011 1968 1.02:1
TextAreaMinimalPerf.default 490 482 1.02:1
TooltipMinimalPerf.default 937 922 1.02:1
Icon.Fluent 672 662 1.02:1
Tooltip.Fluent 689 674 1.02:1
AvatarMinimalPerf.default 209 206 1.01:1
ButtonSlotsPerf.default 575 567 1.01:1
ChatWithPopoverPerf.default 381 378 1.01:1
DatepickerMinimalPerf.default 45502 45208 1.01:1
FlexMinimalPerf.default 313 310 1.01:1
ProviderMinimalPerf.default 937 924 1.01:1
TextMinimalPerf.default 362 357 1.01:1
Avatar.Fluent 336 332 1.01:1
Dialog.Fluent 782 775 1.01:1
Dropdown.Fluent 3081 3045 1.01:1
CardMinimalPerf.default 566 565 1:1
CheckboxMinimalPerf.default 2799 2806 1:1
ItemLayoutMinimalPerf.default 1219 1224 1:1
ListNestedPerf.default 573 574 1:1
MenuButtonMinimalPerf.default 1569 1571 1:1
ProviderMergeThemesPerf.default 1583 1577 1:1
SplitButtonMinimalPerf.default 3770 3753 1:1
StatusMinimalPerf.default 715 718 1:1
TreeMinimalPerf.default 786 787 1:1
Checkbox.Fluent 640 642 1:1
BoxMinimalPerf.default 365 370 0.99:1
ButtonOverridesMissPerf.default 1672 1688 0.99:1
ButtonUseCssPerf.default 805 817 0.99:1
ButtonUseCssNestingPerf.default 1061 1075 0.99:1
ChatDuplicateMessagesPerf.default 290 294 0.99:1
DividerMinimalPerf.default 378 380 0.99:1
LoaderMinimalPerf.default 738 744 0.99:1
MenuMinimalPerf.default 884 891 0.99:1
RadioGroupMinimalPerf.default 446 450 0.99:1
Image.Fluent 393 395 0.99:1
CarouselMinimalPerf.default 491 501 0.98:1
EmbedMinimalPerf.default 4185 4257 0.98:1
Button.Fluent 564 575 0.98:1
AccordionMinimalPerf.default 166 172 0.97:1
HeaderMinimalPerf.default 383 397 0.96:1
Slider.Fluent 1537 1605 0.96:1
GridMinimalPerf.default 354 374 0.95:1
RosterPerf.default 1123 1198 0.94:1

@size-auditor
Copy link

size-auditor bot commented Mar 12, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 151ee1eba7bbf9078ea18cf53495de63678614f0 (build)

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Mar 25, 2021
@ling1726 @joshualamusga1
Fix release CI test (microsoft#17397)
04ef630 
Recently microsoft#17161 changed `react-menu` to use native `jest` command for
testing which does not support the `--production` flag
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@ling1726 @miroslavstastny
Fix release CI test (microsoft#17397)
9473354 
Recently microsoft#17161 changed `react-menu` to use native `jest` command for
testing which does not support the `--production` flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ling1726 @fabricteam @ecraig12345 @khmakoto