Add checkbox implem to Menu #16888
Merged
Add checkbox implem to Menu #16888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oleksandr Fediashov <[email protected]>
…726/fluentui into feat/converged-menu-implem
…726/fluentui into feat/converged-menu-implem
…726/fluentui into feat/converged-menu-implem
packages/react-menu/src/components/MenuItemCheckbox/MenuItemCheckbox.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemRadio/MenuItemRadio.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemRadio/MenuItemRadio.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemRadio/MenuItemRadio.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemRadio/MenuItemRadio.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemRadio/MenuItemRadio.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemCheckbox/MenuItemCheckbox.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-menu/src/components/MenuItemCheckbox/MenuItemCheckbox.test.tsx
Outdated
Show resolved
Hide resolved
….test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]>
| version "7.10.4" | ||
| resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.10.4.tgz#a6724f1a6b8d2f6ea5236dbfe58c7d7ea9c5eb99" | ||
| integrity sha512-UpTN5yUJr9b4EX2CnGNWIvER7Ab83ibv0pcvvHc4UOdrBI5jb8bj+32cCwPX6xu0mt2daFNjYhoi+X7beH0RSw== | ||
| "@babel/runtime@^7.0.0", "@babel/runtime@^7.1.2", "@babel/runtime@^7.10.2", "@babel/runtime@^7.10.3", "@babel/runtime@^7.10.4", "@babel/runtime@^7.12.5", "@babel/runtime@^7.3.1", "@babel/runtime@^7.3.4", "@babel/runtime@^7.4.2", "@babel/runtime@^7.4.4", "@babel/runtime@^7.4.5", "@babel/runtime@^7.5.0", "@babel/runtime@^7.5.5", "@babel/runtime@^7.6.3", "@babel/runtime@^7.7.2", "@babel/runtime@^7.7.4", "@babel/runtime@^7.7.6", "@babel/runtime@^7.8.3", "@babel/runtime@^7.8.4", "@babel/runtime@^7.9.2": |
There was a problem hiding this comment.
I deduplicated @babel/* entries
| @@ -4353,6 +4378,13 @@ | |||
| dependencies: | |||
| "@types/react" "*" | |||
|
|
|||
| "@types/react-test-renderer@>=16.9.0": | |||
There was a problem hiding this comment.
Entries for @types/react-test-renderer cannot be deduplicated, oops
Closed
25 tasks
|
🎉 Handy links: |
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Feb 25, 2021
* Auto-generate react-menu * use correct react-menu version * Update packages/react-menu/package.json Co-authored-by: Oleksandr Fediashov <[email protected]> * update files * remove unnecessary * modified codeowners * update codeowners * modify codeowners * Change files * add react-hooks dep * revert unnecessary files * fix deps * remove unnecessary comments * type ref * use state for selectors * add mising type * remove cast * remove readme * remove default div * remove default div * fix story type * follow package structure * add export * remove placeholder * revert package.json * type refs * Change files * fix deps * move conformance to devdep * update api * fixes to types * remove coment * fix imports * update api * update API * fix types * fix conformance tests * fix exports * add checkbox and tests * add snapshots * use resolution for pretty-format * add checkbox story * fix types * add comment * use storybook decorator * remove imports, fix types * make checkmark mandatory for checkbox * make value/item naming more consistent * move checked to selectable state * Change files * update codeowner for react-menu * hide checkmark instead of not rendering * add testing-library/hooks * revert codeowners * correct tsdoc * fix imports * add icons to checkboxes, fix hover/focus styles * downgrade testing library and resolove testing-library/dom instead * add checkbox implem * update md * use styling hooks * add comment * add events * use separate events for keyboard/click * remove e.persist * Update packages/react-menu/src/components/MenuItemRadio/MenuItemRadio.test.tsx Co-authored-by: Oleksandr Fediashov <[email protected]> * fix tests * fix tests * fix test * add required props for conformance test * ignore confirmance types for now * update snapshots * fix change file * deduplicate @babel/* entires Co-authored-by: Oleksandr Fediashov <[email protected]> Co-authored-by: Elizabeth Craig <[email protected]> Co-authored-by: Oleksandr Fediashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Add checkbox implem to Menu, need to solve the following issues in following PRs:
Focus areas to test
(optional)