Converged menu spec #16517
Merged
Converged menu spec #16517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 18, 2021
Closed
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85c1a4d:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a8004b125ce874302247360efece97645dc0963a (build) |
behowell
reviewed
Jan 20, 2021
paulgildea
reviewed
Jan 22, 2021
jurokapsiar
reviewed
Jan 25, 2021
| </ul> | ||
| Both will also flip appropriately when the overflow boundary is too small. | ||
|
|
||
| The main difference between the two is that v0 submenu's position does not expose any way to customize or override the positioning of the submenu. However v7 allows every single customization as the root menu. It is very possible to do the below: |
There was a problem hiding this comment.
I think it is possible to pass popper props to submenu. @layershifter is it correct?
There was a problem hiding this comment.
Looking at our code I don't think so:
There was a problem hiding this comment.
It is possible but is actually not present in our documentation, it's a hidden prop you can add menu.popper https://fluentsite.z22.web.core.windows.net/0.52.0/components/menu/props
There was a problem hiding this comment.
Just FYI, hidden props mean we failed. Let's ensure we don't do this moving forward. We should consider how to automate testing for these kinds of cases, no hidden props.
levithomason
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
👍 Awesome work @ling1726, thanks much. Can't wait to see the first implementation now :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting feedback of all kinds since I can't find any other specs that follow the new template. I might resolve more complicated discussions for spec review to keep the PR clean to review.
Might be easier on the eyes just to open the file not in review mode
Spec template: https://github.com/microsoft/fluentui/wiki/Spec-Template
(optional)