Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enzyme setup from converged packages #22118

Closed
ecraig12345 opened this issue Mar 16, 2022 · 3 comments · Fixed by #22245
Closed

Remove enzyme setup from converged packages #22118

ecraig12345 opened this issue Mar 16, 2022 · 3 comments · Fixed by #22245
Labels

Comments

@ecraig12345
Copy link
Member

After #22009 merges, we should remove enzyme setup from converged packages (example: packages/react-image/config/tests.js). We could either remove the whole setup file, or just the enzyme parts.

source: #22009 (comment)

@ecraig12345
Copy link
Member Author

@layershifter and/or @Hotell any preference whether to remove the whole Jest setup file for converged packages, or leave it as a placeholder and just remove the enzyme parts? I'm fine with either way.

@layershifter
Copy link
Member

@ecraig12345 We had that discussion with @Hotell before and the conclusion was too keep placeholder files AFAIR.

@Hotell
Copy link
Contributor

Hotell commented Mar 16, 2022

@ecraig12345 We had that discussion with @Hotell before and the conclusion was too keep placeholder files AFAIR.

exactly, also some packages use @testing-library/jest-dom so removing this would break CI. Also please don't forget to update migrate-converged-pkg generator. ty

@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Apr 7, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants