Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-conformance-griffel: remove v8 packages from dependencies #21980

Closed
Hotell opened this issue Mar 7, 2022 · 3 comments
Closed

react-conformance-griffel: remove v8 packages from dependencies #21980

Hotell opened this issue Mar 7, 2022 · 3 comments
Assignees
Labels
Area: Testing Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@Hotell
Copy link
Contributor

Hotell commented Mar 7, 2022

Actual behavior:

After #21924,

  • Dependency tree looks like
graph TD;
A["react-conformance-griffel (v9)"]-->B["react-conformance (v7,8)"]-->npm-3rd-party;
Loading
  • versionGroup needs to be maintained only for this package

Expected behavior:

  • Dependency tree looks like
graph TD;
A["react-conformance-griffel (v9)"] --> npm-3rd-party;
B["react-conformance (v7,8)"] --> npm-3rd-party; 
Loading
  • no versionGroup needed

Implementation

because react-conformance-griffel uses only TestObject type, the simplest option is to dupe that type in griffel package to decouple the dep tree. Because TS is structural type system we wont loose API type checking.

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Sep 8, 2022
@Hotell Hotell reopened this Sep 12, 2022
@Hotell Hotell removed this from the March Project Cycle Q1 2022 milestone Sep 12, 2022
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Jan 23, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 22, 2023
@Hotell
Copy link
Contributor Author

Hotell commented Jun 27, 2023

we will not dupe as there is more than TestObject type being used. In future conformance will be more granular and pluggable which will also improve dep graph and domain boundaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants