-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-conformance-griffel: remove v8 packages from dependencies #21980
Comments
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
we will not dupe as there is more than |
Actual behavior:
After #21924,
Expected behavior:
Implementation
because
react-conformance-griffel
uses onlyTestObject
type, the simplest option is to dupe that type in griffel package to decouple the dep tree. Because TS is structural type system we wont loose API type checking.The text was updated successfully, but these errors were encountered: