Skip to content

Commit

Permalink
fixup! feat(scripts): remove @internal stripping and enable no deps b…
Browse files Browse the repository at this point in the history
…uild needed for api generation
  • Loading branch information
Hotell committed Nov 14, 2022
1 parent d99c29c commit edf3f55
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/tasks/ts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function prepareTsTaskConfig(options: TscTaskOptions) {
if (hasNewCompilationSetup) {
options.outDir = `${tsConfigOutDir}/${options.outDir}`;
} else {
// TODO: remove after all v9 is migrated to new build and .d.ts API stripping
// TODO: remove after all v9 is migrated to new tsc processing
options.baseUrl = '.';
options.rootDir = './src';
}
Expand Down
1 change: 1 addition & 0 deletions scripts/tasks/utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ describe(`utils`, () => {
const defaults = {
tsConfig: {
compilerOptions: {
outDir: '../../dist/out-tsc',
...options.tsConfig?.compilerOptions,
},
},
Expand Down
8 changes: 7 additions & 1 deletion scripts/tasks/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@ export function getTsPathAliasesApiExtractorConfig(options: {
packageJson: PackageJson;
definitionsRootPath: string;
}) {
const normalizedPaths = createNormalizedTsPaths({ definitionsRootPath: options.definitionsRootPath, rootTsConfig });
const hasNewCompilationSetup = ((options.tsConfig.compilerOptions as unknown) as { outDir: string }).outDir.includes(
'dist/out-tsc',
);
// TODO: after all v9 is migrated to new tsc processing use only createNormalizedTsPaths
const normalizedPaths = hasNewCompilationSetup
? createNormalizedTsPaths({ definitionsRootPath: options.definitionsRootPath, rootTsConfig })
: undefined;

/**
* Customized TSConfig that uses `tsconfig.lib.json` as base with some required overrides:
Expand Down

0 comments on commit edf3f55

Please sign in to comment.