chore(scripts-tasks): remove unused apis from api-extractor task

microsoft · Apr 17, 2024 · e4a3d8f · e4a3d8f
1 parent 14eb141
commit e4a3d8f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/scripts/tasks/src/api-extractor.ts b/scripts/tasks/src/api-extractor.ts
@@ -111,8 +111,6 @@ export function apiExtractor(): TaskFunction {
     const compilerConfig = getTsPathAliasesApiExtractorConfig({
       tsConfig: tsConfigs.lib,
       packageJson,
-      pathAliasesTsConfigPath: isLocalBuild ? path.join(workspaceRoot, 'tsconfig.base.json') : undefined,
-      definitionsRootPath: 'dist/out-tsc/types',
     });
 
     // NOTE: internally just-tasks calls `options.onConfigLoaded?.(rawConfig);` so we need to mutate object properties (js passes objects by reference)

diff --git a/scripts/tasks/src/generate-api.ts b/scripts/tasks/src/generate-api.ts
@@ -17,9 +17,7 @@ function generateTypeDeclarations() {
     '--emitDeclarationOnly',
     // turn off path aliases.
     '--baseUrl .',
-  ]
-    .filter(Boolean)
-    .join(' ');
+  ].join(' ');
 
   return execSync(cmd, { stdio: 'inherit' });
 }
diff --git a/scripts/tasks/src/utils.ts b/scripts/tasks/src/utils.ts
@@ -134,8 +134,8 @@ function createNormalizedTsPaths(options: { definitionsRootPath: string; pathAli
 export function getTsPathAliasesApiExtractorConfig(options: {
   tsConfig: TsConfig;
   packageJson: PackageJson;
-  definitionsRootPath: string;
-  pathAliasesTsConfigPath?: string;
+  // definitionsRootPath: string;
+  // pathAliasesTsConfigPath?: string;
 }) {
   const { packageJson, tsConfig /* , pathAliasesTsConfigPath, definitionsRootPath */ } = options;
   /**
@@ -178,7 +178,8 @@ export function getTsPathAliasesApiExtractorConfig(options: {
        * - see https://github.com/microsoft/rushstack/pull/3321, https://github.com/microsoft/rushstack/pull/3339
        *
        */
-      paths: undefined,
+      // FIXME: overriding baseUrl effectively turns-off path aliases resolution, so probably this can be removed
+      // paths: undefined,
       baseUrl: '.',
     },
   };