fixup! feat(scripts-generators): incorporate base all generation to c…

…reate-package and validate integrity on CI
microsoft · Apr 6, 2023 · e056509 · e056509
1 parent 0d01c0f
commit e056509
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/scripts/generators/generate-ts-base-all-json.ts b/scripts/generators/generate-ts-base-all-json.ts
@@ -20,6 +20,7 @@ export function main(options?: yargs.Arguments<{ verify?: boolean }>) {
 
   const { mergedTsConfig, existingTsConfig, tsConfigAllFileName } = createPathAliasesConfig({
     relativeFolderPathFromRoot: '.',
+    writeFileToDisk: verify === false,
   });
 
   if (verify && !isEqual(existingTsConfig, mergedTsConfig)) {

diff --git a/scripts/storybook/src/utils.js b/scripts/storybook/src/utils.js
@@ -359,10 +359,10 @@ function overrideDefaultBabelLoader(options) {
  *
  * Main purpose of this is to be used for build-less DX in webpack in tandem with {@link registerTsPaths}
  *
- * @param {{relativeFolderPathFromRoot?:string}} options
+ * @param {{relativeFolderPathFromRoot?:string,writeFileToDisk?:boolean}} options
  */
 function createPathAliasesConfig(options = {}) {
-  const { relativeFolderPathFromRoot = './dist' } = options;
+  const { relativeFolderPathFromRoot = './dist', writeFileToDisk = true } = options;
   const rootPath = workspaceRoot;
   const mergedTsConfigRoot = path.join(rootPath, relativeFolderPathFromRoot);
   const tsConfigAllFileName = 'tsconfig.base.all.json';
@@ -395,7 +395,9 @@ function createPathAliasesConfig(options = {}) {
     },
   };
 
-  writeJsonFile(tsConfigAllPath, mergedTsConfig);
+  if (writeFileToDisk) {
+    writeJsonFile(tsConfigAllPath, mergedTsConfig);
+  }
 
   return { tsConfigAllPath, tsConfigAllFileName, mergedTsConfig, existingTsConfig };
 }