react-image - Migration to new DX (#18606)

#### Pull request checklist

- [x] Addresses an existing issue: partially implements #18579
- [x] Include a change request file using `$ yarn change`

#### Description of changes

- Migration of package to new DX
- Conversion of styling from SASS to make-styles

change/@fluentui-react-examples-3f727fcf-7626-44ee-bb71-eb52297f248b.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Removal of react-text",
+  "packageName": "@fluentui/react-examples",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-image-d233671d-ccc9-4a09-a080-56f852b30590.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Migrate to new DX",
+  "packageName": "@fluentui/react-image",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

jest.config.js

@@ -7,6 +7,7 @@ module.exports = {
     '<rootDir>/packages/react-text',
     '<rootDir>/packages/react-portal',
     '<rootDir>/packages/react-aria',
+    '<rootDir>/packages/react-image',
     '<rootDir>/packages/react-positioning',
   ],
 };

nx.json

@@ -98,7 +98,7 @@
     "@fluentui/react-icon-provider": { "implicitDependencies": [] },
     "@fluentui/react-icons-mdl2": { "implicitDependencies": [] },
     "@fluentui/react-icons-mdl2-branded": { "implicitDependencies": [] },
-    "@fluentui/react-image": { "implicitDependencies": [] },
+    "@fluentui/react-image": { "tags": ["vNext", "platform:web"], "implicitDependencies": [] },
     "@fluentui/react-input": { "implicitDependencies": [] },
     "@fluentui/react-link": { "implicitDependencies": [] },
     "@fluentui/react-make-styles": { "implicitDependencies": [] },

packages/react-examples/package.json

@@ -53,7 +53,6 @@
     "@fluentui/react-focus": "^8.1.4",
     "@fluentui/react-hooks": "^8.2.2",
     "@fluentui/react-icons-mdl2": "^1.1.3",
-    "@fluentui/react-image": "^9.0.0-alpha.45",
     "@fluentui/react-label": "^9.0.0-alpha.9",
     "@fluentui/react-link": "^9.0.0-alpha.46",
     "@fluentui/react-make-styles": "^9.0.0-alpha.42",

packages/react-image/.storybook/main.js

@@ -0,0 +1,11 @@
+const rootMain = require('../../../.storybook/main');
+
+module.exports = /** @type {Pick<import('../../../.storybook/main').StorybookConfig,'addons'|'stories'|'webpackFinal'>} */ ({
+  stories: [...rootMain.stories, '../src/**/*.stories.mdx', '../src/**/*.stories.@(ts|tsx)'],
+  addons: [...rootMain.addons],
+  webpackFinal: (config, options) => {
+    const localConfig = { ...rootMain.webpackFinal(config, options) };
+
+    return localConfig;
+  },
+});

packages/react-image/.storybook/preview.js

@@ -0,0 +1,3 @@
+import * as rootPreview from '../../../.storybook/preview';
+
+export const decorators = [...rootPreview.decorators];

packages/react-image/.storybook/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "extends": "../tsconfig.json",
+  "compilerOptions": {
+    "allowJs": true,
+    "checkJs": true
+  },
+  "exclude": ["../**/*.test.ts", "../**/*.test.js", "../**/*.test.tsx", "../**/*.test.jsx"],
+  "include": ["../src/**/*", "*.js"]
+}

packages/react-image/config/api-extractor.local.json

@@ -0,0 +1,5 @@
+{
+  "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
+  "extends": "./api-extractor.json",
+  "mainEntryPointFilePath": "<projectFolder>/dist/<unscopedPackageName>/src/index.d.ts"
+}

packages/react-image/jest.config.js

@@ -1,9 +1,21 @@
-const { createConfig } = require('@fluentui/scripts/jest/jest-resources');
-const path = require('path');
+// @ts-check
 
-const config = createConfig({
-  setupFiles: [path.resolve(path.join(__dirname, 'config', 'tests.js'))],
+/**
+ * @type {jest.InitialOptions}
+ */
+module.exports = {
+  displayName: 'react-image',
+  preset: '../../jest.preset.js',
+  globals: {
+    'ts-jest': {
+      tsConfig: '<rootDir>/tsconfig.json',
+      diagnostics: false,
+    },
+  },
+  transform: {
+    '^.+\\.tsx?$': 'ts-jest',
+  },
+  coverageDirectory: './coverage',
+  setupFilesAfterEnv: ['./config/tests.js'],
   snapshotSerializers: ['@fluentui/jest-serializer-make-styles'],
-});
-
-module.exports = config;
+};

packages/react-image/package.json

@@ -18,10 +18,11 @@
     "code-style": "just-scripts code-style",
     "just": "just-scripts",
     "lint": "just-scripts lint",
-    "start": "just-scripts dev:storybook",
-    "start-test": "just-scripts jest-watch",
-    "test": "just-scripts test",
-    "update-snapshots": "just-scripts jest -u"
+    "start": "storybook",
+    "test": "jest",
+    "docs": "api-extractor run --config=config/api-extractor.local.json --local",
+    "build:local": "tsc -p . --module esnext --emitDeclarationOnly && node ../../scripts/typescript/normalize-import --output dist/packages/react-image/src && yarn docs",
+    "storybook": "start-storybook"
   },
   "devDependencies": {
     "@fluentui/babel-make-styles": "^9.0.0-alpha.16",

packages/react-examples/src/react-image/Image/Image.stories.tsx → packages/react-image/src/Image.stories.tsx

@@ -1,14 +1,34 @@
 import * as React from 'react';
-import { Image } from '@fluentui/react-image';
-import * as classes from './Image.stories.scss';
+import { Image } from './index';
+import { makeStyles } from '@fluentui/react-make-styles';
 
 /**
  * Temporary Stack until there's one in its own package.
  */
+const useStackStyles = makeStyles({
+  hStack: {
+    display: 'flex',
+    flexDirection: 'row',
+    flexWrap: 'wrap',
+    margin: 'calc(-1 * var(--gap, 8px) / 2)',
+    '> *': {
+      margin: 'calc(var(--gap, 8px) / 2)',
+    },
+  },
+  vStack: {
+    display: 'flex',
+    flexDirection: 'column',
+    alignItems: 'flex-start',
+    '> *:not(:first-child)': {
+      marginTop: 'var(--gap, 20px)',
+    },
+  },
+});
 const Stack = (props: React.PropsWithChildren<{ horizontal?: boolean }>) => {
   const { horizontal, ...rest } = props;
+  const { hStack, vStack } = useStackStyles();
 
-  return <div {...rest} className={horizontal ? classes.hStack : classes.vStack} />;
+  return <div {...rest} className={horizontal ? hStack : vStack} />;
 };
 
 export const ImageAppearanceShape = () => (
@@ -161,3 +181,8 @@ export const ImageFluid = () => (
     <Image fluid src="https://via.placeholder.com/100x100" />
   </Stack>
 );
+
+export default {
+  title: 'Components/Image',
+  component: Image,
+};

packages/react-image/tsconfig.json

@@ -1,22 +1,17 @@
 {
+  "extends": "../../tsconfig.base.json",
+  "include": ["src"],
   "compilerOptions": {
-    "baseUrl": ".",
+    "target": "ES5",
+    "module": "CommonJS",
+    "lib": ["es5", "dom"],
     "outDir": "dist",
-    "target": "es5",
-    "module": "commonjs",
     "jsx": "react",
     "declaration": true,
-    "sourceMap": true,
     "experimentalDecorators": true,
     "importHelpers": true,
     "noUnusedLocals": true,
-    "forceConsistentCasingInFileNames": true,
-    "strict": true,
-    "moduleResolution": "node",
     "preserveConstEnums": true,
-    "lib": ["es5", "dom"],
-    "typeRoots": ["../../node_modules/@types", "../../typings"],
-    "types": ["jest", "custom-global"]
-  },
-  "include": ["src"]
+    "types": ["jest", "custom-global", "inline-style-expand-shorthand"]
+  }
 }

tsconfig.base.json

@@ -31,7 +31,8 @@
       "@fluentui/react-storybook": ["packages/react-storybook/src/index.ts"],
       "@fluentui/react-accordion": ["packages/react-accordion/src/index.ts"],
       "@fluentui/react-text": ["packages/react-text/src/index.ts"],
-      "@fluentui/react-aria": ["packages/react-aria/src/index.ts"]
+      "@fluentui/react-aria": ["packages/react-aria/src/index.ts"],
+      "@fluentui/react-image": ["packages/react-image/src/index.ts"]
     }
   },
   "exclude": ["node_modules"]

workspace.json

@@ -117,7 +117,11 @@
     "@fluentui/react-icon-provider": { "root": "packages/react-icon-provider", "projectType": "library" },
     "@fluentui/react-icons-mdl2": { "root": "packages/react-icons-mdl2", "projectType": "library" },
     "@fluentui/react-icons-mdl2-branded": { "root": "packages/react-icons-mdl2-branded", "projectType": "library" },
-    "@fluentui/react-image": { "root": "packages/react-image", "projectType": "library" },
+    "@fluentui/react-image": {
+      "root": "packages/react-image",
+      "projectType": "library",
+      "sourceRoot": "packages/react-image/src"
+    },
     "@fluentui/react-input": { "root": "packages/react-input", "projectType": "library" },
     "@fluentui/react-link": { "root": "packages/react-link", "projectType": "library" },
     "@fluentui/react-make-styles": { "root": "packages/react-make-styles", "projectType": "library" },