chore: remove screener dependencies and various screener removal clea…

…nups (#26070)

.devops/templates/runpublishvrscreenshot.yml

@@ -39,11 +39,6 @@ steps:
       fi
     displayName: Check if vrTests should be skipped
 
-  - script: |
-      yarn workspace ${{ parameters.vrTestPackageName }} convert
-    displayName: Convert screener component to storywright
-    condition: and(eq(variables['vrTestSkip'], 'no'), eq('${{ parameters.shouldBuildNorthstar }}', 'false'))
-
   - ${{ if eq(parameters.shouldBuildstorybookaddon, 'true') }}:
       - script: |
           yarn build --to @fluentui/react-storybook-addon
@@ -57,12 +52,12 @@ steps:
         condition: eq(variables['vrTestSkip'], 'no')
 
   - script: |
-      yarn workspace ${{ parameters.vrTestPackageName }} screener:build
+      yarn workspace ${{ parameters.vrTestPackageName }} vr:build
     displayName: Build VR tests components package
     condition: eq(variables['vrTestSkip'], 'no')
 
   - script: |
-      yarn workspace ${{ parameters.vrTestPackageName }} test:component --verbose
+      yarn workspace ${{ parameters.vrTestPackageName }} vr:test --verbose
     displayName: 'Run VR tests'
     condition: eq(variables['vrTestSkip'], 'no')
 

apps/public-docsite-v9/tsconfig.json

@@ -15,7 +15,7 @@
     "moduleResolution": "node",
     "preserveConstEnums": true,
     "skipLibCheck": true,
-    "types": ["webpack-env", "@storybook/react", "screener-storybook"]
+    "types": ["webpack-env", "@storybook/react"]
   },
   "include": ["src"]
 }

apps/vr-tests-react-components/package.json

@@ -5,15 +5,14 @@
   "description": "Visual regression tests for @fluentui/react-components",
   "scripts": {
     "build": "build-storybook -o dist/storybook",
-    "convert": "bash convertStoriesToStoryWright.sh",
     "clean": "just-scripts clean",
     "format": "prettier . -w --ignore-path ../../.prettierignore",
     "lint": "just-scripts lint",
-    "screener:build": "yarn build",
     "start": "start-storybook",
     "test": "just-scripts test",
-    "test:component": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true",
-    "type-check": "tsc"
+    "type-check": "tsc",
+    "vr:build": "yarn build",
+    "vr:test": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true"
   },
   "devDependencies": {
     "@fluentui/eslint-plugin": "*",

apps/vr-tests/package.json

@@ -6,14 +6,13 @@
   "scripts": {
     "build": "just-scripts build",
     "clean": "just-scripts clean",
-    "test:component": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true",
     "code-style": "just-scripts code-style",
-    "convert": "bash convertStoriesToStoryWright.sh",
     "just": "just-scripts",
     "lint": "just-scripts lint",
-    "screener:build": "cross-env NODE_OPTIONS=--max-old-space-size=3072 just-scripts storybook:build",
     "start": "just-scripts dev:storybook",
-    "type-check": "tsc"
+    "type-check": "tsc",
+    "vr:build": "cross-env NODE_OPTIONS=--max-old-space-size=3072 just-scripts storybook:build",
+    "vr:test": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true"
   },
   "devDependencies": {
     "@fluentui/eslint-plugin": "*",

change/@fluentui-eslint-plugin-2519b606-2830-4188-ac39-f985dd576af5.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "nit: replace screener word usage with storywright.",
+  "packageName": "@fluentui/eslint-plugin",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

package.json

@@ -285,7 +285,6 @@
     "satisfied": "^1.1.1",
     "scheduler": "0.20.2",
     "schema-utils": "3.1.1",
-    "screener-storybook": "0.23.0",
     "semver": "^6.2.0",
     "source-map-loader": "4.0.0",
     "storybook-addon-export-to-codesandbox": "0.7.1",

packages/eslint-plugin/src/utils/configHelpers.js

@@ -61,7 +61,7 @@ module.exports = {
    * - config/build
    * - stories, for now
    *   - may need to reconsider for converged components depending on website approach
-   *   - the stories suffix is also used for screener stories in `vr-tests`
+   *   - the stories suffix is also used for storywright stories in `vr-tests`
    */
   devDependenciesFiles: [...testFiles, ...docsFiles, ...configFiles, '**/*.stories.tsx'],
 

packages/fluentui/docs/.storybook/preview.js

@@ -1,6 +1,5 @@
 import * as React from 'react';
 import { Provider, teamsTheme } from '@fluentui/react-northstar';
-import Screener from 'screener-storybook/src/screener';
 
 /** @type {import("@fluentui/react-storybook-addon").FluentParameters} */
 export const parameters = { layout: 'none' };
@@ -18,8 +17,3 @@ export const decorators = [
     );
   },
 ];
-
-// For static storybook per https://github.com/screener-io/screener-storybook#testing-with-static-storybook-app
-if (typeof window === 'object') {
-  /** @type {*} */ (window).__screener_storybook__ = require('@storybook/react').getStorybook;
-}

packages/fluentui/docs/package.json

@@ -70,9 +70,9 @@
     "lint": "eslint --ext .js,.ts,.tsx .",
     "lint:fix": "yarn lint --fix",
     "start": "gulp docs",
-    "screener:build": "yarn build:storybook",
     "start:profile": "cross-env NODE_ENV=production PERF=true gulp docs",
     "start:storybook": "start-storybook",
-    "test:component": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true"
+    "vr:build": "yarn build:storybook",
+    "vr:test": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true"
   }
 }

prettier.config.js

@@ -14,7 +14,7 @@ module.exports = {
     {
       files: 'apps/vr-tests/**/*',
       options: {
-        // The smaller printWidth for the screener tests promotes readability by preventing test cases
+        // The smaller printWidth for the storywright tests promotes readability by preventing test cases
         // from being squished onto one line (and squished up against each other in consecutive lines)
         printWidth: 100,
       },