make-styles: fix types.ts compatibility with typescript < v4 (#19281)

Make-styles: Types.ts was updated in a way that's not compatible with typescript < v4 (named tuples)
microsoft · Aug 6, 2021 · 8a09087 · 8a09087
1 parent d628c61
commit 8a09087
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json b/change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json
@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Make-styles: Types.ts was updated in a way that's not compatible with typescript < v4 (named tuples)",
+  "packageName": "@fluentui/make-styles",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/make-styles/etc/make-styles.api.md b/packages/make-styles/etc/make-styles.api.md
@@ -18,7 +18,7 @@ export function createCSSVariablesProxy(prefix?: string): unknown;
 export function createDOMRenderer(target?: Document | undefined): MakeStylesRenderer;
 
 // @public (undocumented)
-export type CSSClasses = /* ltrClassName */ string | [ltrClassName: string, rtlClassName: string];
+export type CSSClasses = /* ltrClassName */ string | [/* ltrClassName */ string, /* rtlClassName */ string];
 
 // @public (undocumented)
 export type CSSClassesMap = Record<PropertyHash, CSSClasses>;
@@ -50,7 +50,7 @@ export const LOOKUP_DEFINITIONS_INDEX = 0;
 export const LOOKUP_DIR_INDEX = 1;
 
 // @public (undocumented)
-export type LookupItem = [definitions: CSSClassesMap, dir: 'rtl' | 'ltr'];
+export type LookupItem = [/* definitions */ CSSClassesMap, /* dir */ /* dir */ 'rtl' | 'ltr'];
 
 // @public (undocumented)
 export type MakeStaticStyles = ({
@@ -159,7 +159,6 @@ export const styleBucketOrdering: StyleBucketName[];
 // @public (undocumented)
 export type StylesBySlots<Slots extends string | number, Tokens> = Record<Slots, MakeStylesStyleRule<Tokens>>;
 
-
 // (No @packageDocumentation comment for this package)
 
 ```
diff --git a/packages/make-styles/src/types.ts b/packages/make-styles/src/types.ts
@@ -88,7 +88,7 @@ export type StyleBucketName =
 export type SequenceHash = string;
 export type PropertyHash = string;
 
-export type CSSClasses = /* ltrClassName */ string | [ltrClassName: string, rtlClassName: string];
+export type CSSClasses = /* ltrClassName */ string | [/* ltrClassName */ string, /* rtlClassName */ string];
 
 export type CSSClassesMap = Record<PropertyHash, CSSClasses>;
 export type CSSClassesMapBySlot<Slots extends string | number> = Record<Slots, CSSClassesMap>;
@@ -97,4 +97,4 @@ export type CSSRulesByBucket = Partial<Record<StyleBucketName, string[]>>;
 
 export type StylesBySlots<Slots extends string | number, Tokens> = Record<Slots, MakeStylesStyleRule<Tokens>>;
 
-export type LookupItem = [definitions: CSSClassesMap, dir: 'rtl' | 'ltr'];
+export type LookupItem = [/* definitions */ CSSClassesMap, /* dir */ 'rtl' | 'ltr'];