feat(react-utilities): generalize is HTMLElement attribute to unknown (…

…#25991)
microsoft · Dec 22, 2022 · 2d76331 · 2d76331
1 parent d2daecb
commit 2d76331
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/change/@fluentui-react-utilities-7cc076d6-144c-497a-9432-7ed6e01735ae.json b/change/@fluentui-react-utilities-7cc076d6-144c-497a-9432-7ed6e01735ae.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "feat: generalize is HTMLElement attribute to unknown",
+  "packageName": "@fluentui/react-utilities",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/react-utilities/etc/react-utilities.api.md b/packages/react-components/react-utilities/etc/react-utilities.api.md
@@ -73,10 +73,10 @@ export function getTriggerChild<TriggerChildProps>(children: TriggerProps<Trigge
 export function isFluentTrigger(element: React_2.ReactElement): element is React_2.ReactElement<TriggerProps>;
 
 // @internal
-export function isHTMLElement(element?: Node | null | undefined): element is HTMLElement;
+export function isHTMLElement(element?: unknown): element is HTMLElement;
 
 // @internal
-export function isInteractiveHTMLElement(element: Node | null | undefined): boolean;
+export function isInteractiveHTMLElement(element: unknown): boolean;
 
 // @public
 export function isResolvedShorthand<Shorthand extends Slot<UnknownSlotProps>>(shorthand?: Shorthand): shorthand is ExtractSlotProps<Shorthand>;

diff --git a/packages/react-components/react-utilities/src/utils/isHTMLElement.ts b/packages/react-components/react-utilities/src/utils/isHTMLElement.ts
@@ -7,10 +7,11 @@
  * might be problematic while operating with [multiple realms](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof#instanceof_and_multiple_realms)
  *
  */
-export function isHTMLElement(element?: Node | null | undefined): element is HTMLElement {
+export function isHTMLElement(element?: unknown): element is HTMLElement {
+  const typedElement = element as Node | null | undefined;
   return Boolean(
-    element !== null &&
-      element?.ownerDocument?.defaultView &&
-      element instanceof element.ownerDocument.defaultView.HTMLElement,
+    typedElement !== null &&
+      typedElement?.ownerDocument?.defaultView &&
+      typedElement instanceof typedElement.ownerDocument.defaultView.HTMLElement,
   );
 }
diff --git a/packages/react-components/react-utilities/src/utils/isInteractiveHTMLElement.ts b/packages/react-components/react-utilities/src/utils/isInteractiveHTMLElement.ts
@@ -4,7 +4,7 @@ import { isHTMLElement } from './isHTMLElement';
  * @internal
  * Checks that the element has default behaviour from user input on click or 'Enter'/'Space' keys
  */
-export function isInteractiveHTMLElement(element: Node | null | undefined) {
+export function isInteractiveHTMLElement(element: unknown) {
   if (!isHTMLElement(element)) {
     return false;
   }