fix chart crash

microsoft · Jan 28, 2025 · 2828658 · 2828658
1 parent 1ae2f93
commit 2828658
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx b/packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
@@ -198,7 +198,7 @@ export const DeclarativeChart: React.FunctionComponent<DeclarativeChartProps> =
       return <DonutChart {...transformPlotlyJsonToDonutProps(plotlySchema, colorMap, isDarkTheme)} {...commonProps} />;
     case 'bar':
       const orientation = plotlyInput.data[0].orientation;
-      if (orientation === 'h') {
+      if (orientation === 'h' && isNumberArray((plotlyInput.data[0] as PlotData).x)) {
         return (
           <HorizontalBarChartWithAxis
             {...transformPlotlyJsonToHorizontalBarWithAxisProps(plotlySchema, colorMap, isDarkTheme)}
@@ -245,7 +245,8 @@ export const DeclarativeChart: React.FunctionComponent<DeclarativeChartProps> =
         <SankeyChart {...transformPlotlyJsonToSankeyProps(plotlySchema, colorMap, isDarkTheme)} {...commonProps} />
       );
     case 'indicator':
-      if (plotlyInput.data?.[0]?.mode?.includes('gauge')) {
+    case 'gauge':
+      if (plotlyInput.data?.[0]?.mode?.includes('gauge') || plotlyInput.data?.[0]?.type === 'gauge') {
         return (
           <GaugeChart {...transformPlotlyJsonToGaugeProps(plotlySchema, colorMap, isDarkTheme)} {...commonProps} />
         );

diff --git a/packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchema.ts b/packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchema.ts
@@ -1075,7 +1075,9 @@ export type PlotType =
   | 'treemap'
   | 'violin'
   | 'volume'
-  | 'waterfall';
+  | 'waterfall'
+  // adding custom plot types as we get in plotly schemas
+  | 'gauge';
 
 export type Data = Partial<PlotData> | Partial<PieData> | Partial<SankeyData>;