Potential fix for code scanning alert no. 3: Prototype-polluting assignment #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnment Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Saadnajmi
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/microsoft/fluentui-react-native/security/code-scanning/3
To fix the prototype pollution issue, we need to ensure that the
keyvalue used in theensureAndReturnfunction is validated and does not include dangerous property names like__proto__,constructor, orprototype. We can achieve this by adding a check to reject these keys before performing the assignment.Suggested fixes powered by Copilot Autofix. Review carefully before merging.
From Ruriko: I have checked the code and it's in line with the suggestions attached to the CodeQL alert for how to fix the issue.