Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Shimmer background color on Mac #3307

Merged

Conversation

amgleitman
Copy link
Member

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

This change ensures that a Shimmer component's background color gets displayed on macOS. We also make sure that nothing gets drawn outside the border given a large enough corner radius.

Verification

Before After
Screenshot 2023-12-14 at 12 29 17 PM Screenshot 2023-12-14 at 12 29 27 PM

Corner radius fix (pay attention to bottom-right corner)

Before corner radius fix After corner radius fix
Screenshot 2023-12-08 at 5 40 51 PM Screenshot 2023-12-08 at 5 21 21 PM

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@amgleitman amgleitman requested a review from a team as a code owner December 14, 2023 20:34
@amgleitman amgleitman merged commit 4a8aa9d into microsoft:main Dec 15, 2023
11 checks passed
@amgleitman amgleitman deleted the shimmer-background-and-corner-radius branch December 15, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants