Legacy RadioGroup Fix - Narrator announcing selected RadioButton as "non-selected"

[gulnazsayed]

Platforms Impacted

• iOS
• macOS
• win32 (Office)
• windows
• android

Description of changes

This is an accessibility bug fix for legacy RadioGroup where narrator was reading selected RadioButtons as "non-selected." The fix for keyboard focus is similar to the workaround for RadioGroup V1. However, there appears to be an additional timing issue for onPress now where narrator reads "non-selected" for selected RadioButtons where you mouse click on a RadioButton. This issue was not present in RadioGroup V1, even though the events are the same between both legacy and V1, which leads me to think it's a timing issue in legacy RadioGroup. Hence, the fix for onPress is similar to keyboarding, essentially calling changeSelection and setting that it was invoked to set the focus on the current RadioButton.

Verification

No visual changes. Tested manually using Narrator.

Pull request checklist

This PR has considered (when applicable):

• Automated Tests
• Documentation and examples
• Keyboard Accessibility
• Voiceover
• Internationalization and Right-to-left Layouts

[rurikoaraki]

Curious, is there anything stopping the client from using the new Radio group instead? In general we shouldn't be making fixes to the legacy controls, especially if it requires a lot of additional code.

[gulnazsayed]

Curious, is there anything stopping the client from using the new Radio group instead? In general we shouldn't be making fixes to the legacy controls, especially if it requires a lot of additional code.

@rurikoaraki An accessibility bug was filed for this issue that was pushing us out of compliance and since we haven't deprecated the old RadioGroup yet we thought it would be best to fix the issue in the meantime!