Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix win32 high contrast appearance of TabList #3298

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

lawrencewin
Copy link
Contributor

@lawrencewin lawrencewin commented Dec 11, 2023

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Current high contrast appearance of the TabList has multiple UI elements not visible / hard to see on high contrast themes.

This PR fixes this by using hand-selected values vs redline values to make the HC TabList visible and pretty.

Verification

Aquatic Desert Dusk Night Sky
Before image image image image
After image image image image

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@lawrencewin lawrencewin requested a review from a team as a code owner December 11, 2023 17:19
@lawrencewin lawrencewin merged commit d596477 into microsoft:main Dec 14, 2023
11 checks passed
@lawrencewin lawrencewin deleted the tablist-hc-fix branch December 14, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants