Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Initial Tooltip Package #3237

Merged
merged 47 commits into from
Nov 30, 2023
Merged

Publish Initial Tooltip Package #3237

merged 47 commits into from
Nov 30, 2023

Conversation

gulnazsayed
Copy link
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Publishing the initial Tooltip experimental package with basic setup for testing now that there is a working baseline native module to call. Will be iterating on this with additional testing and documentation.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@gulnazsayed gulnazsayed marked this pull request as ready for review November 16, 2023 15:05
@gulnazsayed gulnazsayed requested a review from a team as a code owner November 16, 2023 15:05
@rurikoaraki
Copy link
Collaborator

Please consider breaking up changes in the future into smaller PRs. This is a lot of code to review at once.

@gulnazsayed
Copy link
Contributor Author

Are E2E tests a follow up?

Refers to: apps/E2E/src/Tooltip/consts.ts:3 in e8de9c8. [](commit_id = e8de9c8, deletion_comment = False)

Yes, they will be a follow-up. Including it in another testing PR for easier review once this one is checked in.

@gulnazsayed gulnazsayed enabled auto-merge (squash) November 30, 2023 16:21
@gulnazsayed gulnazsayed merged commit b5a9fde into microsoft:main Nov 30, 2023
11 checks passed
@gulnazsayed gulnazsayed deleted the tooltip/new branch November 30, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rurikoaraki rurikoaraki rurikoaraki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulnazsayed @rurikoaraki