Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Add left and right arrow to stop propagation list #3234

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

rurikoaraki
Copy link
Collaborator

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Add left/right arrows to the stop propagation list for Menu. Partner ask to make sure that arrow keys don't get handled up the stack, since the menu natively handles them.

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@rurikoaraki rurikoaraki requested a review from a team as a code owner November 14, 2023 19:39
@rurikoaraki rurikoaraki merged commit 3fee0c3 into microsoft:main Nov 21, 2023
11 checks passed
@rurikoaraki rurikoaraki deleted the left_right_stop_prop_menu branch November 21, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants