Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react-native 0.72 #3216

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Update to react-native 0.72 #3216

merged 5 commits into from
Nov 9, 2023

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Nov 7, 2023

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Mostly bumping package versions.
Modified a few types that were using number|string for dimensions. In RN these types now use ${number}% instead of string, so we need our types to be similarly restrictive.

Heavy rewrite of the stack components. Switched it to use the newer gap properties. Also substantially reduced the valid values of some of its properties. Many of the value it was trying to use never worked in RN. (Setting padding to "5 10" doesn't work in RN), nor do the "calc" values.

Verification

Build/test. Built the win32 bundle and launched the test app.

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@acoates-ms acoates-ms requested a review from a team as a code owner November 7, 2023 21:55
@acoates-ms acoates-ms enabled auto-merge (squash) November 8, 2023 19:09
@acoates-ms acoates-ms merged commit 4a6a9cd into main Nov 9, 2023
11 checks passed
@acoates-ms acoates-ms deleted the rn72 branch November 9, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants