Fix snapshots / type errors

microsoft · Mar 21, 2024 · 69bf5b7 · 69bf5b7
1 parent 5df7386
commit 69bf5b7
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 7 deletions.
diff --git a/packages/components/Divider/src/Divider.styling.ts b/packages/components/Divider/src/Divider.styling.ts
@@ -1,5 +1,5 @@
 import { useMemo } from 'react';
-import type { ViewProps, ColorValue, StyleProp, ViewStyle } from 'react-native';
+import type { ViewProps, ColorValue } from 'react-native';
 import { Platform } from 'react-native';
 
 import { memoize, mergeProps, mergeStyles } from '@fluentui-react-native/framework';

diff --git a/packages/components/Divider/src/__tests__/Divider.test.tsx b/packages/components/Divider/src/__tests__/Divider.test.tsx
@@ -1,6 +1,5 @@
 import * as React from 'react';
 
-import { checkReRender } from '@fluentui-react-native/test-tools';
 import * as renderer from 'react-test-renderer';
 
 import { Divider } from '../Divider';
@@ -95,8 +94,4 @@ describe('Divider component tests', () => {
     const tree = renderer.create(<CustomDivider {...props}>Hello</CustomDivider>).toJSON();
     expect(tree).toMatchSnapshot();
   });
-
-  it('Divider re-renders correctly', () => {
-    checkReRender(() => <Divider />, 2);
-  });
 });
diff --git a/packages/components/Divider/src/__tests__/__snapshots__/Divider.test.tsx.snap b/packages/components/Divider/src/__tests__/__snapshots__/Divider.test.tsx.snap
@@ -2,6 +2,9 @@
 
 exports[`Divider component tests Branded Divider 1`] = `
 <View
+  alignContent="center"
+  appearance="brand"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -31,6 +34,9 @@ exports[`Divider component tests Branded Divider 1`] = `
 
 exports[`Divider component tests Custom Divider 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -60,6 +66,9 @@ exports[`Divider component tests Custom Divider 1`] = `
 
 exports[`Divider component tests Divider default 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -89,6 +98,18 @@ exports[`Divider component tests Divider default 1`] = `
 
 exports[`Divider component tests Divider with all props + tokens set 1`] = `
 <View
+  alignContent="start"
+  appearance="strong"
+  icon={
+    {
+      "fontSource": {
+        "codepoint": 9827,
+        "fontFamily": "Arial",
+        "fontSize": 32,
+      },
+    }
+  }
+  insetSize={16}
   style={
     {
       "alignItems": "center",
@@ -98,7 +119,7 @@ exports[`Divider component tests Divider with all props + tokens set 1`] = `
       "justifyContent": "center",
       "maxHeight": 200,
       "maxWidth": 200,
-      "minHeight": 40,
+      "minHeight": 84,
       "minWidth": 10,
       "padding": 10,
       "paddingEnd": 10,
@@ -167,6 +188,18 @@ exports[`Divider component tests Divider with all props + tokens set 1`] = `
 
 exports[`Divider component tests Divider with icon 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  icon={
+    {
+      "fontSource": {
+        "codepoint": 9827,
+        "fontFamily": "Arial",
+        "fontSize": 32,
+      },
+    }
+  }
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -229,6 +262,9 @@ exports[`Divider component tests Divider with icon 1`] = `
 
 exports[`Divider component tests Divider with text 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -296,6 +332,9 @@ exports[`Divider component tests Divider with text 1`] = `
 
 exports[`Divider component tests Horizontal Divider with Inset 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  insetSize={16}
   style={
     {
       "alignItems": "center",
@@ -325,6 +364,9 @@ exports[`Divider component tests Horizontal Divider with Inset 1`] = `
 
 exports[`Divider component tests Strong Divider 1`] = `
 <View
+  alignContent="center"
+  appearance="strong"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -354,6 +396,9 @@ exports[`Divider component tests Strong Divider 1`] = `
 
 exports[`Divider component tests Subtle Divider 1`] = `
 <View
+  alignContent="center"
+  appearance="subtle"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -383,6 +428,9 @@ exports[`Divider component tests Subtle Divider 1`] = `
 
 exports[`Divider component tests Vertical Divider 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  insetSize={0}
   style={
     {
       "alignItems": "center",
@@ -413,6 +461,9 @@ exports[`Divider component tests Vertical Divider 1`] = `
 
 exports[`Divider component tests Vertical Divider with Inset 1`] = `
 <View
+  alignContent="center"
+  appearance="default"
+  insetSize={16}
   style={
     {
       "alignItems": "center",