Reverting back to using the Fluent 2 neutral colors in the Azure Theme #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed a few neutral colors to verify that the previous overrides were disabled (dark theme, in order). Light Dark |
Jacqueline-ms
approved these changes
Feb 13, 2025
|
@Hotell Can an authorized contributor merge this in for us? Thank you! |
|
@mainframev Can an authorized contributor merge this in for us? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
AzureDarkThemeandAzureLightThemecomponents by removing the custom neutral color objects, as requested by the designer. Default neutral color objects from Fluent 2 are now being used in the Azure Theme.Simplification of theme creation:
packages/azure-theme/src/components/AzureDarkTheme/AzureDarkTheme.tsx: Removed the import ofneutralColorsDarkand the spread operator forneutralColorsDarkfrom theAzureDarkThemeobject.packages/azure-theme/src/components/AzureLightTheme/AzureLightTheme.tsx: Removed the import ofneutralColorsLightand the spread operator forneutralColorsLightfrom theAzureLightThemeobject.