Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for test app crashes for 12 schema data #108

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes for test app crashes for 12 schema data #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87b0cff
Fixes for test app crashes for 12 schema data
srmukher Jan 2, 2025
eade7df
Keeping the schema type same which will be handled by default type
srmukher Jan 6, 2025
ecc136e
Merge branch 'main' of https://github.com/microsoft/fluentui-charting…
srmukher Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions apps/plotly_examples/src/components/DeclarativeChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import * as React from 'react';
import { TextField, ITextFieldStyles } from '@fluentui/react/lib/TextField';
import {
import {
srmukher marked this conversation as resolved.
Show resolved Hide resolved
Dropdown,
Option,
SelectionEvents,
OptionOnSelectData,
Subtitle1,
Subtitle2,
Divider
Divider
} from '@fluentui/react-components';
import { DeclarativeChart, IDeclarativeChart, Schema } from '@fluentui/react-charting';
import PlotlyChart from './PlotlyChart';
Expand Down Expand Up @@ -108,23 +108,23 @@ export class DeclarativeChartBasicExample extends React.Component<IDeclarativeCh
// Nothing to do here
}
}
const bgcolor= theme === "Dark" ? "rgb(17,17,17)" : "white"; // Full layout for dark mode https://jsfiddle.net/3hfq7ast/
const fontColor = {"font": { "color": "white" }}
const bgcolor = theme === "Dark" ? "rgb(17,17,17)" : "white"; // Full layout for dark mode https://jsfiddle.net/3hfq7ast/
const fontColor = { "font": { "color": "white" } }
const layout_with_theme = { ...layout, plot_bgcolor: bgcolor, paper_bgcolor: bgcolor, font: fontColor };
const plotlySchema = { data, layout: layout_with_theme, selectedLegends: this._lastKnownValidLegends };
const inputSchema: Schema = { plotlySchema };
return (
<div key={uniqueKey}>
<Subtitle1 align="center" style={{marginLeft:'30%'}}>Declarative chart from fluent</Subtitle1>
<Subtitle1 align="center" style={{ marginLeft: '30%' }}>Declarative chart from fluent</Subtitle1>
<div style={{ display: 'flex' }}>
<label> Select a schema:</label>&nbsp;&nbsp;&nbsp;
<Dropdown
<Dropdown
value={this.state.selectedChoice}
onOptionSelect={this._onChange}
>
{schemasData.map((data) => (
<Option value={(data.schema as { id: string }).id}>{data.fileName}</Option>
))}
<Option value={(data.schema as { id: string }).id}>{data.fileName}</Option>
))}
</Dropdown>
&nbsp;&nbsp;&nbsp;
</div>
Expand All @@ -141,8 +141,7 @@ export class DeclarativeChartBasicExample extends React.Component<IDeclarativeCh
<div data-testid="chart-container" >
<br />
<br />
<Subtitle2>{selectedSchema.layout.title}</Subtitle2>
<Divider/>
<Subtitle2>{typeof selectedSchema.layout.title === 'string' ? selectedSchema.layout.title : typeof selectedSchema.layout.title.text === 'string' ? selectedSchema.layout.title.text : JSON.stringify(selectedSchema.layout.title)}</Subtitle2>
<br />
<br />
<ErrorBoundary>
Expand All @@ -159,16 +158,16 @@ export class DeclarativeChartBasicExample extends React.Component<IDeclarativeCh
value={this.state.selectedLegends}
onChange={this._onSelectedLegendsEdited}
styles={textFieldStyles}
/>
<br/>
/>
<br />
<div key={plotlyKey}>
<Divider/>
<br/>
<Subtitle1 align="center" style={{marginLeft:'30%'}}>Chart from plotly.js</Subtitle1>
<Divider />
<br />
<Subtitle1 align="center" style={{ marginLeft: '30%' }}>Chart from plotly.js</Subtitle1>
<br />
<br />
<ErrorBoundary>
<PlotlyChart schema={plotlySchema}/>
<PlotlyChart schema={plotlySchema} />
</ErrorBoundary>
</div>
</div>
Expand Down
Loading