Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Announce DatePickerController changes in VoiceOver #2134

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Feb 20, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

  • Create a new NSAccessibilityStepper for the header, making it possible to read and change the value of the header as one entire element.
  • Add an NSAccessibility announcement when the visible month in the DatePickerController changes.
  • Clean up TestDatePickerController so popover-hosted picker works as expected.

Binary change

n/a, no Mac size testing

Verification

  • Verified VoiceOver announcements happen for all three date pickers in the test screen.
  • Ensured announcements happen exactly once, and only when the picker changes (not on initial appearance).
Stepper.mov

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner February 20, 2025 23:32
@mischreiber mischreiber merged commit 4c0c69b into microsoft:main Mar 19, 2025
7 checks passed
@mischreiber mischreiber deleted the announceDatePickerChanges branch March 19, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants