Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Updating Version.plist keys to match other plists #2096

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Oct 16, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The FluentUI_iOS library was using different keys to store its version info compared to every other plist in the repo. Let's just consolidate onto the same standard CFBundleVersion/CFBundleShortVersionString naming pattern, to make version increases easier.

Binary change

Before After Delta
16,525,060 16,525,126 62 bytes

Verification

Ran the BumpVersion.swift script to confirm that the new plist is correctly updated.

Visual Verification

Simulator Screenshot - iPhone 16 Pro - 2024-10-16 at 16 09 31

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner October 16, 2024 23:12
@mischreiber mischreiber enabled auto-merge (squash) October 16, 2024 23:12
@mischreiber mischreiber merged commit 1ef7f33 into microsoft:main Oct 16, 2024
7 checks passed
@mischreiber mischreiber deleted the renameVersionPlistKeys branch October 17, 2024 00:31
@mischreiber mischreiber mentioned this pull request Oct 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants