Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping to 0.27.0 #1991

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

ghuang24
Copy link
Contributor

@ghuang24 ghuang24 commented Apr 1, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Changes since 0.26.0

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@ghuang24 ghuang24 requested review from a team as code owners April 1, 2024 20:10
Copy link
Contributor

@joannaquu joannaquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo plist should be bumped as well. See #1988 as an example

Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you follow these steps to bump the version https://github.com/microsoft/fluentui-apple/wiki/Fluent-Version-Update?

Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update the PR with which changes are going into this new version. Reference: #1983

@ghuang24 ghuang24 requested a review from laminesm April 2, 2024 18:40
Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need admin approval for these changes. Fyi @mischreiber @harrieshin @anandrajeswaran

@mischreiber
Copy link
Contributor

mischreiber commented Apr 3, 2024

You'll need admin approval for these changes. Fyi @mischreiber @harrieshin @anandrajeswaran

Yep, waiting for updates to the branch/notes with the latest changes that'll be going into 0.27. @ghuang24 FYI

@ghuang24
Copy link
Contributor Author

ghuang24 commented Apr 3, 2024

@mischreiber I'm new to committing to this repo - is there somewhere else I need to add the update notes? The changes are in the PR description

@laminesm
Copy link
Contributor

laminesm commented Apr 3, 2024

@mischreiber I'm new to committing to this repo - is there somewhere else I need to add the update notes? The changes are in the PR description

#1992 was merged yesterday so it should be added to the description as part of 0.27.0 release as well

@mischreiber
Copy link
Contributor

One more:

@mischreiber mischreiber merged commit 3da41ed into microsoft:main Apr 4, 2024
7 checks passed
@harrieshin harrieshin mentioned this pull request Apr 9, 2024
12 tasks
@KeithA45 KeithA45 mentioned this pull request Jul 16, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants