Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2210
This pull request includes changes to the
remove_mention_text
method inturn_context.py
and adds a new test case intest_turn_context.py
to ensure the method works correctly with custom mentions.Improvements to
remove_mention_text
method:libraries/botbuilder-core/botbuilder/core/turn_context.py
: Modified theremove_mention_text
method to handle cases where the mention text is not directly available by using either thetext
orname
property fromadditional_properties
.Additions to test cases:
libraries/botbuilder-core/tests/test_turn_context.py
: Added a new test casetest_should_remove_custom_mention_from_activity
to verify that theremove_mention_text
method correctly removes custom mentions from the activity text.