Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kata-CC: Enforce a restrictive pod security policy #7030

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Kata-CC: Enforce a restrictive pod security policy #7030

merged 2 commits into from
Jan 24, 2024

Conversation

ms-mahuber
Copy link
Contributor

@ms-mahuber ms-mahuber commented Dec 15, 2023 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

With our upstream kata-containers fork being able to enforce a restrictive policy through a variable, this package change now transitions to enforcing a restrictive security policy for CC pods

Change Log
  • Enforce a restrictive policy for CC pods
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Manual testing using a pre-release Kata-CC image with the package changes, and using pod YAMLS with and w/o policy annotations

@ms-mahuber ms-mahuber changed the title Mahuber/sprt/katacc new branch [DO-NOT-MERGE] Kata-CC: Enforce a restrictive pod security policy Dec 15, 2023
@ms-mahuber ms-mahuber changed the base branch from sprt/katacc-new-branch to main January 22, 2024 21:54
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jan 22, 2024
@ms-mahuber ms-mahuber changed the base branch from main to sprt/katacc-new-branch January 22, 2024 21:55
@ms-mahuber ms-mahuber force-pushed the mahuber/sprt/katacc-new-branch branch from fbc23a3 to 3381c2e Compare January 22, 2024 22:01
@ms-mahuber ms-mahuber changed the base branch from sprt/katacc-new-branch to main January 22, 2024 22:02
@ms-mahuber ms-mahuber changed the title [DO-NOT-MERGE] Kata-CC: Enforce a restrictive pod security policy Kata-CC: Enforce a restrictive pod security policy Jan 22, 2024
@ms-mahuber ms-mahuber marked this pull request as ready for review January 23, 2024 01:00
@ms-mahuber ms-mahuber requested a review from a team as a code owner January 23, 2024 01:00
dallasd1
dallasd1 reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@dallasd1 dallasd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump the release version and changelog

@ms-mahuber
Copy link
Contributor Author

Can we bump the release version and changelog

sigh - thanks for catching this. I forgot to add this back when I updated the outdated changes

@ms-mahuber ms-mahuber merged commit c694541 into main Jan 24, 2024
11 checks passed
@ms-mahuber ms-mahuber deleted the mahuber/sprt/katacc-new-branch branch January 24, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprt sprt sprt approved these changes

@dallasd1 dallasd1 dallasd1 approved these changes

Assignees
No one assigned
Labels
main PR Destined for main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-mahuber @sprt @dallasd1