-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cloud-provider-kubevirt as a new package to SPECS #12587
base: 3.0-dev
Are you sure you want to change the base?
Adding cloud-provider-kubevirt as a new package to SPECS #12587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please also take a look at the comment/question I left.
Golden Container image build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=752308 |
154715c
to
a5fb905
Compare
Patch0: Initialization-and-Configuration-handling.patch | ||
Patch1: Single-IP-Address-for-Node.patch | ||
Patch2: Golang-Version-Upgrade.patch | ||
%global debug_package %{nil} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no debug package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following -
https://github.com/microsoft/azurelinux/blob/3.0/SPECS/kubevirt/kubevirt.spec#L42
I am not sure what value needs to be given here.
SPECS/cloud-provider-kubevirt/Initialization-and-Configuration-handling.patch
Outdated
Show resolved
Hide resolved
SPECS/cloud-provider-kubevirt/Initialization-and-Configuration-handling.patch
Outdated
Show resolved
Hide resolved
SPECS/cloud-provider-kubevirt/Initialization-and-Configuration-handling.patch
Outdated
Show resolved
Hide resolved
SPECS/cloud-provider-kubevirt/Initialization-and-Configuration-handling.patch
Outdated
Show resolved
Hide resolved
Golden Container image build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=759855&view=results |
b787922
to
58f8a49
Compare
Rebased on top of latest |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Azure Local (Nexus) requires the functionality of creating a Kubernetes cluster inside a Kubevirt VM to run the workload cluster and managing this VM from the undercloud. In order to do this, they use a component called the cloud-provider-kubevirt (https://github.com/kubevirt/cloud-provider-kubevirt).
The KubeVirt cloud-provider allows a Kubernetes cluster running in KubeVirt VMs (tenant cluster) to interact with KubeVirt and Kubernetes (infrastructure cluster) to provision, manage and clean up resources.
We have been maintaining a local fork of this upstream repository on ADO (https://dev.azure.com/mariner-org/ECF/_git/cloud-provider-kubevirt) and this thread is to get the approvals to maintain this upstream repository as an RPM package and move away from maintaining a fork of the changes.
Justification to merge this package
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology
Validating the container image:
Trivy Scan Results for the new container image
_acrafoimages.azurecr.io/base/cloud-provider-kubevirt:0.5.1-1-azl3.0.20250219-amd64 (azurelinux 3.0)
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)_