Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch cloud-hypervisor-cvm for CVE-2024-12797 [High] #12424

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Patch cloud-hypervisor-cvm for CVE-2024-12797 [High] #12424

merged 5 commits into from
Feb 20, 2025

Conversation

Kanishk-Bansal
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner February 15, 2025 23:05
sameluch
sameluch approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@sameluch sameluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please fix indentation as noted by Falak

@Kanishk-Bansal
Copy link
Contributor Author

Approved, but please fix indentation as noted by Falak

Fixed

christopherco
christopherco requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reviewed by @microsoft/cbl-mariner-kata-containers

Redent0r
Redent0r reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@Redent0r Redent0r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disregard my approval above. I'm rerunning validation simmilar to #12425 (comment) just to double check :)

Redent0r
Redent0r approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@Redent0r Redent0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation passed
bb: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=737325&view=results
image: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=740396&view=results
conf: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=740492&view=ms.vss-test-web.build-test-results-tab
perf: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=740498&view=ms.vss-test-web.build-test-results-tab

@jslobodzian jslobodzian merged commit 5abb2b9 into fasttrack/3.0 Feb 20, 2025
10 checks passed
@jslobodzian jslobodzian deleted the kanbansal/cloud-hypervisor-cvm/CVE-2024-12797/3.0 branch February 20, 2025 21:49
CBL-Mariner-Bot pushed a commit that referenced this pull request Feb 20, 2025
@Kanishk-Bansal @CBL-Mariner-Bot
Patch cloud-hypervisor-cvm for CVE-2024-12797 [High] (#12424)
2950efc 
Co-authored-by: Sam Meluch <[email protected]>
Co-authored-by: jslobodzian <[email protected]>
(cherry picked from commit 5abb2b9)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Feb 20, 2025
Open
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=741450&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw mfrw approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

@Redent0r Redent0r Redent0r approved these changes

@christopherco christopherco christopherco approved these changes

@sameluch sameluch sameluch approved these changes

Assignees
No one assigned
Labels
fasttrack/3.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kanishk-Bansal @CBL-Mariner-Bot @mfrw @jslobodzian @Redent0r @christopherco @sameluch