PR check for terraform, redis, fdk-aac-free, opus and packer #12253
Conversation
microsoft-github-policy-service
bot
added
the
3.0-dev
|
|
||
| on: | ||
| push: | ||
| branches: [main, dev, 1.0*, 2.0*, 3.0*, fasttrack/*] |
There was a problem hiding this comment.
We can probably disregard dev and 1.0 both above this comment and below this comment
| version=$(rpmspec --parse "$spec" | grep -E "^Version:\s*(.*)" | awk '{print $2}') | ||
|
|
||
| #if fdk-aac-free or opus are changed, check if the version is the same as the previous version | ||
| if [[ "$name" == "fdk-aac-free" || "$name" == "opus" ]]; then |
There was a problem hiding this comment.
so we want to make sure that fdk-aac-free, opus and opus-file are NOT re-introduced. Not sure why we would be looking for a previous version,
There was a problem hiding this comment.
Similar comment here as below, we probably should take this from a simple data file that we can iterate through.
There was a problem hiding this comment.
updated. added a new csv file
| fi | ||
| fi | ||
| # Check if the version is greater than the allowed version | ||
| if { [[ "$name" == "redis" && "$(printf '%s\n' "$version" "7.4" | sort -V | head -n1)" == "7.4" ]] || \ |
There was a problem hiding this comment.
Python may have been a better language choice here. We should at least create an Associative Array where the package name can be the key and the version number it's maximum value. Then iterate through these. Even better, we might just have a CSV style data file to iterate through.
There was a problem hiding this comment.
added a new csv file
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
We are not letting some of the packages to be updated using this PR check gate.
i) redis cannot be updated to 7.4 and above
ii) packer cannot be updated to 1.10.0 and above
iii) terraform cannot be updated to 1.6.0 and above
iv) no version bump or addition of fdk-aac-free opus-file, and opus.
Change Log
Does this affect the toolchain?
YES/NO
NO
Test Methodology