Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch python-tqdm for CVE-2024-34062 #12248

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

Kanishk-Bansal
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal commented Feb 6, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner February 6, 2025 19:25
@Kanishk-Bansal Kanishk-Bansal changed the title Patch CVE-2024-34062 for python-tqdm Patch python-tqdm for CVE-2024-34062 Feb 6, 2025
@Kanishk-Bansal Kanishk-Bansal marked this pull request as draft February 6, 2025 20:28
@Kanishk-Bansal Kanishk-Bansal marked this pull request as ready for review February 6, 2025 20:36
Copy link
Contributor

@suresh-thelkar suresh-thelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I have a minor comment. Please take a look.

@sameluch
Copy link
Contributor

rerunning PR checks, python-tqdm ptest is timing out on arm64

@jslobodzian jslobodzian merged commit d4a15c7 into fasttrack/3.0 Feb 19, 2025
11 of 15 checks passed
@jslobodzian jslobodzian deleted the kanbansal/python-tqdm/CVE-2024-34062/3.0 branch February 19, 2025 01:49
CBL-Mariner-Bot pushed a commit that referenced this pull request Feb 19, 2025
Co-authored-by: Sam Meluch <[email protected]>
Co-authored-by: KavyaSree2610 <[email protected]>
(cherry picked from commit d4a15c7)
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants