Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing generate_source_tarball.sh for helm to match other scripts #12143

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

mbykhovtsev-ms
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms commented Jan 30, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Following PRs like #12065, this PR aims to modify existing generate_source_tarball.sh scripts for helm to use the same parameters and behavior as other go vendored packages. So it adds new parameter to the script and modifies the vendored file name to match the naming scheme.

Change Log
  • Adds vendorVersion parameter to helm make the scripts use it for naming to add v1 versioning for vendored files
  • Renames vendored files for helm to use govendor-v1 naming in it
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: xxxx

@mbykhovtsev-ms mbykhovtsev-ms requested a review from a team as a code owner January 30, 2025 00:53
@mbykhovtsev-ms mbykhovtsev-ms changed the base branch from 3.0 to 3.0-dev January 30, 2025 00:54
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0 PRs Destined for 3.0 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 3.0 PRs Destined for 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant