Upgrade golang/x/net for CVE-2023-39325 and CVE-2023-44487 #12125
+61
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjswalling
force-pushed
the
gaswal/app-gw-cve
branch
from
6d22e22 to
e87be71
Compare
|
I noticed that |
| @@ -20,12 +20,10 @@ Source0: https://github.com/Azure/application-gateway-kubernetes-ingress/ | |||
| # --mtime="2021-04-26 00:00Z" \ | |||
| # --owner=0 --group=0 --numeric-owner \ | |||
| # --pax-option=exthdr.name=%d/PaxHeaders/%f,delete=atime,delete=ctime \ | |||
| # -cf %%{name}-%%{version}-vendor.tar.gz vendor | |||
| # -cf %%{name}-%%{version}-%%{release}-vendor.tar.gz vendor | |||
| # | |||
| Source1: %{name}-%{version}-vendor.tar.gz | |||
There was a problem hiding this comment.
Suggested change
| Source1: %{name}-%{version}-vendor.tar.gz | |
| Source1: %{name}-%{version}-govendor-v1.tar.gz |
This should be changed to match the new format of %{name}-%{version}-govendor-v1.tar.gz (or v2, v3, etc). Although this is an updated tarball for the same version, I'm inclined to go with v1 since we don't have a v1 right now, and it'll help keep things consistent for any future work.
| @@ -20,12 +20,10 @@ Source0: https://github.com/Azure/application-gateway-kubernetes-ingress/ | |||
| # --mtime="2021-04-26 00:00Z" \ | |||
| # --owner=0 --group=0 --numeric-owner \ | |||
| # --pax-option=exthdr.name=%d/PaxHeaders/%f,delete=atime,delete=ctime \ | |||
| # -cf %%{name}-%%{version}-vendor.tar.gz vendor | |||
| # -cf %%{name}-%%{version}-%%{release}-vendor.tar.gz vendor | |||
There was a problem hiding this comment.
With the script, this set of steps isn't necessary anymore. If you do wish to keep it, though, -cf should be -czf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Upgrade golang/x/net for CVE-2023-39325 and CVE-2023-44487
Change Log
Does this affect the toolchain?
NO
Links to CVEs
Test Methodology