-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cert-manager: Address CVE-2024-12401 #11784
cert-manager: Address CVE-2024-12401 #11784
Conversation
Signed-off-by: Ankita Pareek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch includes an addition of a binary file, however the build error suggests that you cannot include binary file changes as git diff patch. Unfortunately, that means that this cannot be patched like a regular patch and package upgrade is the only solution. I have checked and this patch is included in starting version 1.12.14
. I think that is the only way to get this CVE patched for us.
cert-manager has been upgraded to 1.12.15 recently. Does this CVE still apply with the upgrade? Is this PR still needed? |
No it should not be needed anymore as versions |
This CVE is already fixed with the .15 version of cert-manager |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Address CVE-2024-12401 in the cert-manager package
Change Log
Does this affect the toolchain?
NO
Links to CVEs
Test Methodology