Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding systemd patch for CVE-2023-7008 #11315

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Adding systemd patch for CVE-2023-7008 #11315

merged 12 commits into from
Jan 14, 2025

Conversation

Adub17030MS
Copy link
Contributor

@Adub17030MS Adub17030MS commented Dec 4, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

The systemd package has the following cve: CVE-2023-7008. This PR adds the corresponding patch to fix the cve.

Change Log
  • Added patch file
  • Updated changelog
  • Updated signed spec to have same release version
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Pipeline build id: Build run
    • Note: package tests fail currently but these failures are unrelated to the changes made in this PR and these ptests have been failing on 3.0-dev

@Adub17030MS Adub17030MS changed the base branch from 3.0 to 3.0-dev December 4, 2024 22:53
@Adub17030MS Adub17030MS changed the title adding patch for CVE-2023-7008 Adding patch for CVE-2023-7008 Dec 10, 2024
@Adub17030MS Adub17030MS changed the title Adding patch for CVE-2023-7008 Adding systemd patch for CVE-2023-7008 Dec 10, 2024
@Adub17030MS Adub17030MS marked this pull request as ready for review December 11, 2024 00:06
@Adub17030MS Adub17030MS requested a review from a team as a code owner December 11, 2024 00:06
anphel31
anphel31 previously approved these changes Dec 11, 2024
View reviewed changes
@Adub17030MS Adub17030MS changed the base branch from 3.0-dev to fasttrack/3.0 December 11, 2024 19:53
@Adub17030MS Adub17030MS dismissed anphel31’s stale review December 11, 2024 19:53

The base branch was changed.

@mbykhovtsev-ms
Copy link
Contributor

A headsup we have merged a release-bump of both of these spec files to 19 release version on 3.0 branch and its currently on hold to sync fasttrack/3.0 with 3.0. Once we do it, this will have merge conflict and you will need to just increment release version to 20

@jslobodzian jslobodzian merged commit 97f9494 into fasttrack/3.0 Jan 14, 2025
14 of 18 checks passed
@jslobodzian jslobodzian deleted the adityadubey/systemd-CVE-2023-7008 branch January 14, 2025 19:53
CBL-Mariner-Bot pushed a commit that referenced this pull request Jan 14, 2025
@Adub17030MS @CBL-Mariner-Bot
Adding systemd patch for CVE-2023-7008 (#11315)
a03dae4 
Co-authored-by: Sam Meluch <[email protected]>
(cherry picked from commit 97f9494)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Jan 14, 2025
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=711244&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslobodzian jslobodzian jslobodzian approved these changes

@dmcilvaney dmcilvaney dmcilvaney approved these changes

@anphel31 anphel31 anphel31 left review comments

Assignees
No one assigned
Labels
fasttrack/3.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Adub17030MS @mbykhovtsev-ms @CBL-Mariner-Bot @jslobodzian @anphel31 @dmcilvaney @sameluch