-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mic][iso] Save input ISO configuration as yaml #10743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
636efef
to
c9444dc
Compare
c9444dc
to
1122521
Compare
'SavedConfigs' is a subset of the Image Customizer input configurations that needs to be saved on the output media so that it can be used in subsequent runs of the Image Customizer against that same output media. This preservation of input configuration is necessary for subsequent runs if the configuration does not result in updating root file system. For example, if the user specifies a kernel argument that is specific to the ISO image, it will not be present in any of the grub config files on the root file system - only in the final ISO image grub.cfg. When that ISO image is further customized, the root file system grub.cfg migith get re-generated and we need to remember to add the ISO specific arguments from the previous runs. SavedConfigs is the place where we can store such arguments so we can re-apply them.
1122521
to
ef6c344
Compare
cwize1
requested changes
Oct 18, 2024
cwize1
approved these changes
Oct 18, 2024
cwize1
approved these changes
Oct 19, 2024
durgajagadeesh
pushed a commit
to durgajagadeesh/azurelinux_djpalli
that referenced
this pull request
Dec 31, 2024
'SavedConfigs' is a subset of the Image Customizer input configurations that needs to be saved on the output media so that it can be used in subsequent runs of the Image Customizer against that same output media. This change updates the code from saving just the kernel parameters in a plain-text file, to saving the same yaml that's using in the input configuration. This allows the code to scale when we want to save other input configuration constructs. This is a step preparing for adding PXE specific configurations. Background: This preservation of input configuration is necessary for subsequent runs if the configuration does not result in updating root file system. For example, if the user specifies a kernel argument that is specific to the ISO image, it will not be present in any of the grub config files on the root file system - only in the final ISO image grub.cfg. When that ISO image is further customized, the root file system grub.cfg migith get re-generated and we need to remember to add the ISO specific arguments from the previous runs. SavedConfigs is the place where we can store such arguments so we can re-apply them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
[mix][iso] Save input ISO configuration as yaml.
'SavedConfigs' is a subset of the Image Customizer input configurations that needs to be saved on the output media so that it can be used in subsequent runs of the Image Customizer against that same output media.
This change updates the code from saving just the kernel parameters in a plain-text file, to saving the same yaml that's using in the input configuration. This allows the code to scale when we want to save other input configuration constructs. This is a step preparing for adding PXE specific configurations.
Background:
This preservation of input configuration is necessary for subsequent runs if the configuration does not result in updating root file system.
For example, if the user specifies a kernel argument that is specific to the ISO image, it will not be present in any of the grub config files on the root file system - only in the final ISO image grub.cfg. When that ISO image is further customized, the root file system grub.cfg migith get re-generated and we need to remember to add the ISO specific arguments from the previous
runs. SavedConfigs is the place where we can store such arguments so we can re-apply them.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology