Skip to content

dracut: Drop dracut multiple confdirs patch #10071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Camelron
Copy link
Contributor

@Camelron Camelron commented Aug 8, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
0007-feat-dracut.sh-support-multiple-config-dirs introduces the ability to invoke dracut with a non-standard dracut conf directory. We have no mechanism to utilize this feature, doubly so after dropping mkinitrd.sh from our distro.

The scenario of supporting multiple kernel flavors on one image is not a realistic one. As a distro, we should favor shipping specific kernels on specific images for specific intended target platforms.

This feature is intended mainly for kernels which supply/support different sets of modules/features but this is not needed because above decision. Dropping the patch.

Change Log
  • Drop 0007-feat-dracut.sh-support-multiple-config-dirs.patch
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@Camelron Camelron requested a review from a team as a code owner August 8, 2024 22:24
@Camelron Camelron changed the title Drop dracut multiple confdirs patch dracut: Drop dracut multiple confdirs patch Aug 8, 2024
@Camelron Camelron merged commit 2f4184f into 3.0-dev Aug 19, 2024
12 checks passed
@Camelron Camelron deleted the cameronbaird/dracut-drop-confdirs branch August 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants