-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust coreutils branch #10057
base: 3.0-dev
Are you sure you want to change the base?
Rust coreutils branch #10057
Conversation
@@ -0,0 +1,151 @@ | |||
Summary: Rust reimplementation of GNU core utilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we get into the review and clean-up, could you provide more details about this change? Why is it needed? What's the scenario we're trying to support?
@microsoft-github-policy-service agree company="Microsoft" |
Signed-off-by: Chris Co <[email protected]>
Signed-off-by: Chris Co <[email protected]>
Signed-off-by: Chris Co <[email protected]>
Signed-off-by: Chris Co <[email protected]>
Signed-off-by: Chris Co <[email protected]>
URL: https://github.com/uutils/coreutils | ||
Source0: %{url}/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz | ||
# Below is a automatically created tarball with no download link. | ||
Source1: rust-coreutils-0.0.26-vendored.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the vendored tarballs, please create a generate_source_tarball.sh
script. They are used by the auto-upgrade pipelines to generate new tarballs during an upgrade and they also serve as pointers to how the tarball can be recreated.
%setup -q -n coreutils-%{version} | ||
tar --strip-components=1 -xzf %{SOURCE1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: can we build the vendored tarball, so that we don't need --strip-components=1
? We can also switch to %autosetup
and end up with this:
%setup -q -n coreutils-%{version} | |
tar --strip-components=1 -xzf %{SOURCE1} | |
%autosetup -q -n coreutils-%{version} -a 1 |
See SPECS/blobfuse2/blobfuse2.spec
for instance.
Summary
Adds rust-coreutils (Rust implementation of GNU coreutils) to the SPECS-EXTENDED directory.
Change Log
Does this affect the toolchain?
NO