Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust coreutils branch #10057

Open
wants to merge 7 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

Tonisal-byte
Copy link

Summary

Adds rust-coreutils (Rust implementation of GNU coreutils) to the SPECS-EXTENDED directory.

Change Log
  • rust-coreutils added
Does this affect the toolchain?

NO

@Tonisal-byte Tonisal-byte requested review from a team as code owners August 7, 2024 21:12
@Tonisal-byte Tonisal-byte changed the base branch from 3.0 to 3.0-dev August 7, 2024 21:12
@@ -0,0 +1,151 @@
Summary: Rust reimplementation of GNU core utilities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we get into the review and clean-up, could you provide more details about this change? Why is it needed? What's the scenario we're trying to support?

@Tonisal-byte
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Aug 9, 2024
URL: https://github.com/uutils/coreutils
Source0: %{url}/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz
# Below is a automatically created tarball with no download link.
Source1: rust-coreutils-0.0.26-vendored.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the vendored tarballs, please create a generate_source_tarball.sh script. They are used by the auto-upgrade pipelines to generate new tarballs during an upgrade and they also serve as pointers to how the tarball can be recreated.

Comment on lines +24 to +25
%setup -q -n coreutils-%{version}
tar --strip-components=1 -xzf %{SOURCE1}
Copy link
Contributor

@PawelWMS PawelWMS Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: can we build the vendored tarball, so that we don't need --strip-components=1? We can also switch to %autosetup and end up with this:

Suggested change
%setup -q -n coreutils-%{version}
tar --strip-components=1 -xzf %{SOURCE1}
%autosetup -q -n coreutils-%{version} -a 1

See SPECS/blobfuse2/blobfuse2.spec for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants