-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArcBox - Security enhancements #2907
Open
janegilring
wants to merge
15
commits into
microsoft:main
Choose a base branch
from
janegilring:arcbox_key_vault_secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
…mandatory parameter Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
…tity Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the
azure_jumpstart_arcbox
project, focusing on simplifying parameter handling, enhancing security, and improving role assignments. The most important changes are summarized below:Parameter Handling Simplification:
adminPassword
,spnClientSecret
,azdataPassword
,registryPassword
) fromBootstrap.ps1
andclientVm.bicep
, simplifying the scripts by reducing the number of required inputs. [1] [2]commandToExecute
inclientVm.bicep
to reflect the removal of these parameters.Security Enhancements:
AZDATA_PASSWORD
from Azure Key Vault to usewindowsAdminPassword
instead inDataOpsLogonScript.ps1
.windowsAdminPassword
andregistryPassword
usingnewGuid()
inmain.bicep
. [1] [2]windowsAdminPassword
andregistryPassword
in Azure Key Vault as secrets inmgmtArtifacts.bicep
.Role Assignments:
clientVm.bicep
.VM Management:
ArcServersLogonScript.ps1
to ensure the changes take effect immediately.These changes collectively enhance the security and manageability of the Azure Jumpstart ArcBox deployment scripts.