Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for thought field in AzureAIChatCompletionClient #6062

Merged

Conversation

jay-thakur
Copy link
Contributor

Why are these changes needed?

added support for the thought process in tool calls for OpenAIChatCompletionClient, allowing additional text produced by a model alongside tool calls to be preserved in the thought field of CreateResult. This PR extends the same functionality to AzureAIChatCompletionClient for consistency across model clients.

Related issue number

#5650

Checks

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.75%. Comparing base (47ffacc) to head (50bee50).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6062      +/-   ##
==========================================
+ Coverage   76.65%   76.75%   +0.10%     
==========================================
  Files         191      191              
  Lines       13222    13226       +4     
==========================================
+ Hits        10135    10152      +17     
+ Misses       3087     3074      -13     
Flag Coverage Δ
unittests 76.75% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test similar to the one for testing thought field OpenAIChatCompletionClient?

@ekzhu ekzhu merged commit 7047fb8 into microsoft:main Mar 25, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants