Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory component base #5380

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Conversation

EItanya
Copy link
Contributor

@EItanya EItanya commented Feb 5, 2025

Why are these changes needed?

Currently the way to accomplish RAG behavior with agent chat, specifically assistant agents is with the memory interface, however there is no way to configure it via the declarative API.

Related issue number

Checks

@EItanya
Copy link
Contributor Author

EItanya commented Feb 5, 2025

Hey @victordibia, I opened this PR in response to your PR with ChromaDB. I think it's important that memory is configurable via the declarative syntax as well.

@victordibia
Copy link
Collaborator

victordibia commented Feb 5, 2025

Yup, absolutely correct! also builds on #5149

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (be3c60b) to head (5984a91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5380      +/-   ##
==========================================
+ Coverage   77.87%   77.93%   +0.05%     
==========================================
  Files         158      158              
  Lines        9520     9539      +19     
==========================================
+ Hits         7414     7434      +20     
+ Misses       2106     2105       -1     
Flag Coverage Δ
unittests 77.93% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EItanya EItanya marked this pull request as ready for review February 5, 2025 21:32
@EItanya
Copy link
Contributor Author

EItanya commented Feb 5, 2025

Ok, I think I fixed up the formatting and tests!

@victordibia victordibia self-requested a review February 6, 2025 00:06
@victordibia victordibia merged commit 172a16a into microsoft:main Feb 6, 2025
65 checks passed
@EItanya EItanya deleted the memory-component-base branch February 6, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants