-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory component base #5380
Memory component base #5380
Conversation
…ry-component-base
Hey @victordibia, I opened this PR in response to your PR with ChromaDB. I think it's important that memory is configurable via the declarative syntax as well. |
Yup, absolutely correct! also builds on #5149 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5380 +/- ##
==========================================
+ Coverage 77.87% 77.93% +0.05%
==========================================
Files 158 158
Lines 9520 9539 +19
==========================================
+ Hits 7414 7434 +20
+ Misses 2106 2105 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok, I think I fixed up the formatting and tests! |
Why are these changes needed?
Currently the way to accomplish RAG behavior with agent chat, specifically assistant agents is with the memory interface, however there is no way to configure it via the declarative API.
Related issue number
Checks