Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted M1 agent system prompt to remove TERMINATE #5263

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

afourney
Copy link
Member

Removed the TERMINATE clause from the system prompt since M1 handles termination via the Orchestrator, and it is just ignored.

Removed the clause about saving to a particular file name, since tmp_ files are created in the current CodeExecutors.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.41%. Comparing base (fff201f) to head (3228a2c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5263       +/-   ##
===========================================
- Coverage   83.70%   70.41%   -13.29%     
===========================================
  Files          60      179      +119     
  Lines        2817    11619     +8802     
===========================================
+ Hits         2358     8182     +5824     
- Misses        459     3437     +2978     
Flag Coverage Δ
unittests 70.41% <ø> (-13.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afourney afourney merged commit aa23093 into main Jan 30, 2025
66 checks passed
@afourney afourney deleted the remove_terminate_from_m1coder branch January 30, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants